VM support for running Kernel binaries.

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/atomic.h"
 #include "vm/globals.h"
@@ skipping 198 matching lines @@
   kSmiTagMask = 1,
   kSmiTagShift = 1,
 };
 
 enum TypedDataElementType {
 #define V(name) k##name##Element,
 CLASS_LIST_TYPED_DATA(V)
 #undef V
 };
 
+enum {
+  kNoDilNode = 0

[rmacnak, 2016/10/13 00:56:39]

NULL

[Vyacheslav Egorov (Google), 2016/10/13 14:37:58]

Good point. Done.

+};
+
 #define SNAPSHOT_WRITER_SUPPORT()                                              \
   void WriteTo(                                                                \
       SnapshotWriter* writer, intptr_t object_id,                              \
       Snapshot::Kind kind, bool as_reference);                                 \
   friend class SnapshotWriter;                                                 \
 
 #define VISITOR_SUPPORT(object)                                                \
   static intptr_t Visit##object##Pointers(Raw##object* raw_obj,                \
                                           ObjectPointerVisitor* visitor);
 
@@ skipping 633 matching lines @@
 #endif
   }
 
   NOT_IN_PRECOMPILED(TokenPosition token_pos_);
   NOT_IN_PRECOMPILED(TokenPosition end_token_pos_);
   NOT_IN_PRECOMPILED(int32_t usage_counter_);  // Accessed from generated code
                                                // (JIT only).
   uint32_t kind_tag_;  // See Function::KindTagBits.
   int16_t num_fixed_parameters_;
   int16_t num_optional_parameters_;  // > 0: positional; < 0: named.
+  NOT_IN_PRECOMPILED(intptr_t dil_function_);

[rmacnak, 2016/10/13 00:56:39]

void* ?

I think it would make more sense to have a alternate version of Script that
pointed to some DIL instead of a TokenStream, rather than make any heap objects
bigger.

[Kevin Millikin (Google), 2016/10/13 04:38:35]

That's a good idea.  We do  have that. jenj@ is currently changing our treatment
of scripts as part of adding source positions for stack traces, debugging, and
profiling and a new script kind is part of those changes.

We have postponed shrinking instances by reusing fields, but now is probably a
good time to do that.

[Vyacheslav Egorov (Google), 2016/10/13 14:37:58]

I made it void*.

We can try to fold it into Script later.

As said multiple times before - increase in heap consumption is negligible and
it will go away later. 

   NOT_IN_PRECOMPILED(uint16_t optimized_instruction_count_);
   NOT_IN_PRECOMPILED(uint16_t optimized_call_site_count_);
   NOT_IN_PRECOMPILED(int8_t deoptimization_counter_);
   NOT_IN_PRECOMPILED(int8_t was_compiled_);
 };
 
 
 class RawClosureData : public RawObject {
  private:
   RAW_HEAP_OBJECT_IMPLEMENTATION(ClosureData);
@@ skipping 75 matching lines @@
   TokenPosition token_pos_;
   classid_t guarded_cid_;
   classid_t is_nullable_;  // kNullCid if field can contain null value and
                            // any other value otherwise.
   // Offset to the guarded length field inside an instance of class matching
   // guarded_cid_. Stored corrected by -kHeapObjectTag to simplify code
   // generated on platforms with weak addressing modes (ARM, MIPS).
   int8_t guarded_list_length_in_object_offset_;
 
   uint8_t kind_bits_;  // static, final, const, has initializer....
+  intptr_t dil_field_;

[rmacnak, 2016/10/13 00:56:39]

void* ?

[Vyacheslav Egorov (Google), 2016/10/13 14:37:58]

Done. Also made it NOT_IN_PRECOMPILED.

 
   friend class CidRewriteVisitor;
 };
 
 
 class RawLiteralToken : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(LiteralToken);
 
   RawObject** from() {
     return reinterpret_cast<RawObject**>(&ptr()->literal_);
@@ skipping 1505 matching lines @@
   COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
                  kTypedDataInt8ArrayViewCid + 15);
   COMPILE_ASSERT(kByteBufferCid == kExternalTypedDataInt8ArrayCid + 14);
   COMPILE_ASSERT(kNullCid == kByteBufferCid + 1);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_