media/mojo/services/service_factory_impl.h - Issue 2411573002: media: Use new wrapper types for media mojo interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/service_factory_impl.h

Issue 2411573002: media: Use new wrapper types for media mojo interfaces (Closed)

Patch Set: comments addressed Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/service_factory_impl.h

diff --git a/media/mojo/services/service_factory_impl.h b/media/mojo/services/service_factory_impl.h

index 9df6b6ab281eea0b1700075ecc90ae12d38db450..c7fec624f01354c3ee2c8e3174e79e63461cd5dc 100644

--- a/media/mojo/services/service_factory_impl.h

+++ b/media/mojo/services/service_factory_impl.h

@@ -37,7 +37,7 @@ class ServiceFactoryImpl : public mojom::ServiceFactory {

// mojom::ServiceFactory implementation.

void CreateAudioDecoder(mojom::AudioDecoderRequest request) final;

void CreateVideoDecoder(mojom::VideoDecoderRequest request) final;

- void CreateRenderer(const mojo::String& audio_device_id,

+ void CreateRenderer(const std::string& audio_device_id,

mojom::RendererRequest request) final;

void CreateCdm(mojom::ContentDecryptionModuleRequest request) final;