Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: media/mojo/interfaces/media_types.mojom

Issue 2411573002: media: Use new wrapper types for media mojo interfaces (Closed)
Patch Set: comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/interfaces/decryptor.mojom ('k') | media/mojo/interfaces/platform_verification.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/media_types.mojom
diff --git a/media/mojo/interfaces/media_types.mojom b/media/mojo/interfaces/media_types.mojom
index 88feb20527d3c2ddcc89ba6c6666ea30236b4778..e26e98769660e202396c20b83608fbe16945b3f4 100644
--- a/media/mojo/interfaces/media_types.mojom
+++ b/media/mojo/interfaces/media_types.mojom
@@ -220,7 +220,7 @@ struct AudioDecoderConfig {
SampleFormat sample_format;
ChannelLayout channel_layout;
int32 samples_per_second;
- array<uint8>? extra_data;
+ array<uint8> extra_data;
mojo.common.mojom.TimeDelta seek_preroll;
int32 codec_delay;
EncryptionScheme encryption_scheme;
@@ -236,7 +236,7 @@ struct VideoDecoderConfig {
gfx.mojom.Size coded_size;
gfx.mojom.Rect visible_rect;
gfx.mojom.Size natural_size;
- array<uint8>? extra_data;
+ array<uint8> extra_data;
EncryptionScheme encryption_scheme;
};
@@ -264,9 +264,8 @@ struct DecoderBuffer {
// Indicates whether or not this buffer is a random access point.
bool is_key_frame;
- // This is backed by an std::vector and results in a few copies.
- // Into the vector, onto and off the MessagePipe, back into a vector.
- array<uint8>? side_data;
+ // Empty when |side_data| doesn't exist.
+ array<uint8> side_data;
// DecryptConfig for a encrypted buffer. NULL if the buffer is not encrypted.
DecryptConfig? decrypt_config;
@@ -302,8 +301,8 @@ struct AudioBuffer {
// Timestamp in microseconds of the first frame.
mojo.common.mojom.TimeDelta timestamp;
- // Channel data. Will be null for EOS buffers.
- array<uint8>? data;
+ // Channel data. Will be empty for EOS buffers.
+ array<uint8> data;
};
// This defines a mojo transport format for media::VideoFrame.
« no previous file with comments | « media/mojo/interfaces/decryptor.mojom ('k') | media/mojo/interfaces/platform_verification.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698