Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5370)

Unified Diff: chrome/browser/chromeos/accessibility/speech_monitor.cc

Issue 2410773003: Make ChromeVox Next the default ChromeVox experience (Closed)
Patch Set: Remove obsolete prefix and classic sticky tests; update others to assume next is default. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/speech_monitor.cc
diff --git a/chrome/browser/chromeos/accessibility/speech_monitor.cc b/chrome/browser/chromeos/accessibility/speech_monitor.cc
index 07a4e6c02f91fdda5a7c51febc5fdea980ff5362..775f36998d043ff495bf9340daed75e1738d34b7 100644
--- a/chrome/browser/chromeos/accessibility/speech_monitor.cc
+++ b/chrome/browser/chromeos/accessibility/speech_monitor.cc
@@ -8,6 +8,8 @@ namespace chromeos {
namespace {
const char kChromeVoxEnabledMessage[] = "chrome vox spoken feedback is ready";
+const char kChromeVoxUpdateNotificationMessage[] =
+ "n to learn more about chrome vox Next.";
} // anonymous namespace
SpeechMonitor::SpeechMonitor() {
@@ -30,6 +32,8 @@ std::string SpeechMonitor::GetNextUtterance() {
}
bool SpeechMonitor::SkipChromeVoxEnabledMessage() {
+ bool saw_enabled_message = false;
+ bool saw_update_message = false;
while (true) {
if (utterance_queue_.empty()) {
loop_runner_ = new content::MessageLoopRunner();
@@ -38,7 +42,9 @@ bool SpeechMonitor::SkipChromeVoxEnabledMessage() {
}
std::string result = utterance_queue_.front();
utterance_queue_.pop_front();
- if (result == kChromeVoxEnabledMessage)
+ saw_enabled_message |= result == kChromeVoxEnabledMessage;
+ saw_update_message |= result == kChromeVoxUpdateNotificationMessage;
+ if (saw_enabled_message && saw_update_message)
return true;
}
return false;
« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698