Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2410773003: Make ChromeVox Next the default ChromeVox experience (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
achuithb, dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, achuith+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeVox Next the default ChromeVox experience - removes obsolete key configuration code from options; this leaves options as a simple, clean list of documentable settings - change the tutorial url to point to the Next tutorial Pending/Optional - change the update notification to point to a release note (rather than the tutorial) BUG=613255, 618097 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6 Cr-Commit-Position: refs/heads/master@{#426632}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test. #

Patch Set 3 : Remove obsolete prefix and classic sticky tests; update others to assume next is default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -379 lines) Patch
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 2 10 chunks +35 lines, -136 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html View 1 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 1 5 chunks +0 lines, -208 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 1 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
David Tseng
4 years, 2 months ago (2016-10-11 18:41:45 UTC) #3
dmazzoni
lgtm
4 years, 2 months ago (2016-10-12 15:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410773003/1
4 years, 2 months ago (2016-10-12 17:46:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/279460) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-12 17:51:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410773003/1
4 years, 2 months ago (2016-10-14 18:42:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/281583)
4 years, 2 months ago (2016-10-14 18:54:55 UTC) #14
David Tseng
+achuith@ for c/b/c/login
4 years, 2 months ago (2016-10-14 21:12:26 UTC) #16
achuithb
lgtm https://codereview.chromium.org/2410773003/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc File chrome/browser/chromeos/login/session/user_session_manager.cc (right): https://codereview.chromium.org/2410773003/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc#newcode1234 chrome/browser/chromeos/login/session/user_session_manager.cc:1234: start_urls.push_back(url); Why not start_urls.push_back(kChromeVoxTutorialURLPattern);
4 years, 2 months ago (2016-10-17 21:37:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410773003/1
4 years, 2 months ago (2016-10-19 15:31:44 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/299055)
4 years, 2 months ago (2016-10-19 16:41:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410773003/20001
4 years, 2 months ago (2016-10-19 22:49:20 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/256838)
4 years, 2 months ago (2016-10-20 00:13:23 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410773003/40001
4 years, 2 months ago (2016-10-20 21:14:18 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 22:57:58 UTC) #31
Peter Kasting
A revert of this CL (patchset #3 id:40001) has been created in https://chromiumcodereview.appspot.com/2438893004/ by pkasting@chromium.org. ...
4 years, 2 months ago (2016-10-21 01:52:38 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:02 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6
Cr-Commit-Position: refs/heads/master@{#426632}

Powered by Google App Engine
This is Rietveld 408576698