Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: content/browser/device_sensors/device_sensor_host.h

Issue 2410123002: Remove content::BrowserThread knowledge from Device Sensors (Closed)
Patch Set: Rebase, avoid object creation on startup Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_ 5 #ifndef CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_
6 #define CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_ 6 #define CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/shared_memory.h" 9 #include "base/memory/shared_memory.h"
10 #include "base/sequenced_task_runner.h"
10 #include "content/browser/device_sensors/device_sensors_consts.h" 11 #include "content/browser/device_sensors/device_sensors_consts.h"
11 #include "device/sensors/public/interfaces/light.mojom.h" 12 #include "device/sensors/public/interfaces/light.mojom.h"
12 #include "device/sensors/public/interfaces/motion.mojom.h" 13 #include "device/sensors/public/interfaces/motion.mojom.h"
13 #include "device/sensors/public/interfaces/orientation.mojom.h" 14 #include "device/sensors/public/interfaces/orientation.mojom.h"
14 #include "mojo/public/cpp/bindings/interface_request.h" 15 #include "mojo/public/cpp/bindings/interface_request.h"
15 16
16 namespace content { 17 namespace content {
17 18
18 // A base class for device sensor related mojo interface implementations. 19 // A base class for device sensor related mojo interface implementations.
19 template <typename MojoInterface, ConsumerType consumer_type> 20 template <typename MojoInterface, ConsumerType consumer_type>
20 class DeviceSensorHost : public MojoInterface { 21 class DeviceSensorHost : public MojoInterface {
21 public: 22 public:
22 static void Create(mojo::InterfaceRequest<MojoInterface> request); 23 static void Create(scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
24 mojo::InterfaceRequest<MojoInterface> request);
23 25
24 // All methods below to be called on the IO thread. 26 // All methods below to be called on the IO thread.
25 ~DeviceSensorHost() override; 27 ~DeviceSensorHost() override;
26 28
27 private: 29 private:
28 DeviceSensorHost(); 30 explicit DeviceSensorHost(
31 scoped_refptr<base::SequencedTaskRunner> ui_task_runner);
29 32
30 void StartPolling( 33 void StartPolling(
31 const typename MojoInterface::StartPollingCallback& callback) override; 34 const typename MojoInterface::StartPollingCallback& callback) override;
32 void StopPolling() override; 35 void StopPolling() override;
33 36
34 bool is_started_; 37 bool is_started_;
35 38
39 scoped_refptr<base::SequencedTaskRunner> ui_task_runner_;
36 base::ThreadChecker thread_checker_; 40 base::ThreadChecker thread_checker_;
37 41
38 DISALLOW_COPY_AND_ASSIGN(DeviceSensorHost); 42 DISALLOW_COPY_AND_ASSIGN(DeviceSensorHost);
39 }; 43 };
40 44
41 using DeviceLightHost = 45 using DeviceLightHost =
42 DeviceSensorHost<device::mojom::LightSensor, CONSUMER_TYPE_LIGHT>; 46 DeviceSensorHost<device::mojom::LightSensor, CONSUMER_TYPE_LIGHT>;
43 using DeviceMotionHost = 47 using DeviceMotionHost =
44 DeviceSensorHost<device::mojom::MotionSensor, CONSUMER_TYPE_MOTION>; 48 DeviceSensorHost<device::mojom::MotionSensor, CONSUMER_TYPE_MOTION>;
45 using DeviceOrientationHost = DeviceSensorHost<device::mojom::OrientationSensor, 49 using DeviceOrientationHost = DeviceSensorHost<device::mojom::OrientationSensor,
46 CONSUMER_TYPE_ORIENTATION>; 50 CONSUMER_TYPE_ORIENTATION>;
47 using DeviceOrientationAbsoluteHost = 51 using DeviceOrientationAbsoluteHost =
48 DeviceSensorHost<device::mojom::OrientationAbsoluteSensor, 52 DeviceSensorHost<device::mojom::OrientationAbsoluteSensor,
49 CONSUMER_TYPE_ORIENTATION_ABSOLUTE>; 53 CONSUMER_TYPE_ORIENTATION_ABSOLUTE>;
50 54
51 } // namespace content 55 } // namespace content
52 56
53 #endif // CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_ 57 #endif // CONTENT_BROWSER_DEVICE_SENSORS_DEVICE_SENSOR_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698