Add UMA metrics for window selection and overview.

Add UMA metrics for window selection and overview.

BUG=290995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224287

[flackr, 2013-09-19 18:33:21]

Hi Scott, this CL adds some useful metrics to help determine how effective
overview is. PTAL, thanks!

[sky, 2013-09-19 20:43:15]

LGTM

https://codereview.chromium.org/24096024/diff/5001/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/24096024/diff/5001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:92: UMA_WINDOW_OVERVIEW,
Add description of these, they aren't particularly obvious.

[flackr, 2013-09-19 22:18:52]

https://codereview.chromium.org/24096024/diff/5001/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/24096024/diff/5001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:92: UMA_WINDOW_OVERVIEW,
On 2013/09/19 20:43:16, sky wrote:
> Add description of these, they aren't particularly obvious.

Done.

[commit-bot: I haz the power, 2013-09-19 22:20:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/24096024/10001

[commit-bot: I haz the power, 2013-09-19 22:36:20]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[flackr, 2013-09-19 22:43:42]

+isherman for OWNERS approval on tools/metrics/histograms/histograms.xml

[Ilya Sherman, 2013-09-19 23:08:04]

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
File ash/wm/overview/window_selector_controller.cc (right):

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
ash/wm/overview/window_selector_controller.cc:86:
shell->delegate()->RecordUserMetricsAction(UMA_WINDOW_SELECTION);
Why is this gated on whether or not the last_selection_time_ is null?

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
ash/wm/overview/window_selector_controller.cc:89: base::Time::Now() -
last_selection_time_);
Hmm, is LONG_TIMES really enough?  I'd expect it to be common to spend more than
an hour between uses of this feature.  I'd recommend using a CUSTOM_COUNTS
histogram and emitting (base::Time::Now() - last_selection_time_).InMinutes(),
covering a bigger range than just one hour.

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:260: +    the window selection.
What is "the window selection"?  Could you expand this description a bit to
clarify for folks like myself who are not super familiar with the jargon of this
feature?

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:266: +    The amount of time between
using overview or alt tab cycling to select
I think it would be clearer to phrase this along the lines of "The amount of
time between uses of the overview mode to select windows.  The overview mode can
be entered either by alt-tabbing or by pressing the overview button."  The two
key changes are "uses of" in place of "using", and splitting off the description
of the ways to access the feature from the name of the feature, making for a
less complex first sentence.  Feel free to improve the wording further, but I'd
recommend keeping those two properties :)

[flackr, 2013-09-19 23:23:44]

Expanded on the time between use as well. Thanks!

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
File ash/wm/overview/window_selector_controller.cc (right):

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
ash/wm/overview/window_selector_controller.cc:86:
shell->delegate()->RecordUserMetricsAction(UMA_WINDOW_SELECTION);
On 2013/09/19 23:08:04, Ilya Sherman wrote:
> Why is this gated on whether or not the last_selection_time_ is null?

Good catch, this should not be.

https://codereview.chromium.org/24096024/diff/10001/ash/wm/overview/window_se...
ash/wm/overview/window_selector_controller.cc:89: base::Time::Now() -
last_selection_time_);
On 2013/09/19 23:08:04, Ilya Sherman wrote:
> Hmm, is LONG_TIMES really enough?  I'd expect it to be common to spend more
than
> an hour between uses of this feature.  I'd recommend using a CUSTOM_COUNTS
> histogram and emitting (base::Time::Now() - last_selection_time_).InMinutes(),
> covering a bigger range than just one hour.

In terms of usage, I think the exact timing beyond an hour isn't important. I'd
like to know if selection restarts very shortly after a previous selection,
indicative of choosing the wrong window and alt-tabbing again immediately, and
if power users use alt-tab / overview fairly regularly to switch windows, which
I suspect they do

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:260: +    the window selection.
On 2013/09/19 23:08:04, Ilya Sherman wrote:
> What is "the window selection"?  Could you expand this description a bit to
> clarify for folks like myself who are not super familiar with the jargon of
this
> feature?

Done.

https://codereview.chromium.org/24096024/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:266: +    The amount of time between
using overview or alt tab cycling to select
On 2013/09/19 23:08:04, Ilya Sherman wrote:
> I think it would be clearer to phrase this along the lines of "The amount of
> time between uses of the overview mode to select windows.  The overview mode
can
> be entered either by alt-tabbing or by pressing the overview button."  The two
> key changes are "uses of" in place of "using", and splitting off the
description
> of the ways to access the feature from the name of the feature, making for a
> less complex first sentence.  Feel free to improve the wording further, but
I'd
> recommend keeping those two properties :)

Done.

[Ilya Sherman, 2013-09-19 23:26:58]

LGTM, thanks.

[commit-bot: I haz the power, 2013-09-19 23:35:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/24096024/23001

[commit-bot: I haz the power, 2013-09-20 04:35:33]

Change committed as 224287