Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

Issue 2409523002: [Command buffer] Fix the bug when blitting pixels outside read framebuffer (Closed)
Patch Set: Addressed Corentin's feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/config/gpu_driver_bug_list_json.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 3736 matching lines...) Expand 10 before | Expand all | Expand 10 after
3747 EXPECT_CALL(*gl_, CheckFramebufferStatusEXT(GL_READ_FRAMEBUFFER)) 3747 EXPECT_CALL(*gl_, CheckFramebufferStatusEXT(GL_READ_FRAMEBUFFER))
3748 .WillOnce(Return(GL_FRAMEBUFFER_COMPLETE)) 3748 .WillOnce(Return(GL_FRAMEBUFFER_COMPLETE))
3749 .RetiresOnSaturation(); 3749 .RetiresOnSaturation();
3750 SetupExpectationsForFramebufferClearing(GL_DRAW_FRAMEBUFFER, // target 3750 SetupExpectationsForFramebufferClearing(GL_DRAW_FRAMEBUFFER, // target
3751 GL_COLOR_BUFFER_BIT, // clear bits 3751 GL_COLOR_BUFFER_BIT, // clear bits
3752 0, 0, 0, 0, // color 3752 0, 0, 0, 0, // color
3753 0, // stencil 3753 0, // stencil
3754 1.0f, // depth 3754 1.0f, // depth
3755 false, // scissor test 3755 false, // scissor test
3756 0, 0, 128, 64); 3756 0, 0, 128, 64);
3757 EXPECT_CALL(*gl_, BlitFramebufferEXT(0, 0, 1, 1, 0, 0, 1, 1, 3757 EXPECT_CALL(*gl_, BlitFramebufferEXT(0, 0, _, _, 0, 0, _, _,
3758 GL_COLOR_BUFFER_BIT, GL_LINEAR)) 3758 GL_COLOR_BUFFER_BIT, GL_LINEAR))
3759 .Times(1) 3759 .Times(1)
3760 .RetiresOnSaturation(); 3760 .RetiresOnSaturation();
3761 BlitFramebufferCHROMIUM cmd; 3761 BlitFramebufferCHROMIUM cmd;
3762 cmd.Init(0, 0, 1, 1, 0, 0, 1, 1, GL_COLOR_BUFFER_BIT, GL_LINEAR); 3762 cmd.Init(0, 0, 1, 1, 0, 0, 1, 1, GL_COLOR_BUFFER_BIT, GL_LINEAR);
3763 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd)); 3763 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
3764 EXPECT_EQ(GL_NO_ERROR, GetGLError()); 3764 EXPECT_EQ(GL_NO_ERROR, GetGLError());
3765 } 3765 }
3766 } 3766 }
3767 3767
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
3845 EXPECT_EQ(GL_NO_ERROR, GetGLError()); 3845 EXPECT_EQ(GL_NO_ERROR, GetGLError());
3846 } 3846 }
3847 } 3847 }
3848 3848
3849 // TODO(gman): PixelStorei 3849 // TODO(gman): PixelStorei
3850 3850
3851 // TODO(gman): SwapBuffers 3851 // TODO(gman): SwapBuffers
3852 3852
3853 } // namespace gles2 3853 } // namespace gles2
3854 } // namespace gpu 3854 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/config/gpu_driver_bug_list_json.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698