Remove MessageLoop::current() from history_url_provider.cc

Remove MessageLoop::current() from history_url_provider.cc

Whenever possible, use Thread/SequencedTaskRunnerHandle::Get() instead
of MessageLoop::current(). Thread/SequencedTaskRunnerHandle::Get() work
within TaskScheduler while MessageLoop::current() doesn't.

Good reasons to use MessageLoop::current():
- Add destruction, nesting or task observers.
- Run nested loops.

Bad reasons to use MessageLoop::current():
- Post tasks. Use Thread/SequencedTaskRunnerHandle::Get() instead.
- Watch a file descriptor. Use FileDescriptorWatcher instead.
- Verify that it is possible to post tasks to the current thread.
  Use Thread/SequencedTaskRunnerHandle::IsSet() instead.
- Verify that code runs on a specific thread. Use
  SingleThreadTaskRunner::BelongsToCurrentThread() instead.

BUG=650723
Committed: https://crrev.com/5686c9eb004698df3b62f4e3d63e1ceaca0eff4e
Cr-Commit-Position: refs/heads/master@{#426474}

[fdoray, 2016-10-11 18:20:29]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 18:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-10-11 19:43:44]

fdoray@chromium.org changed reviewers:
+ juberti@chromium.org

[fdoray, 2016-10-11 19:43:45]

PTAL

[commit-bot: I haz the power, 2016-10-11 19:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:45:57]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-10-19 13:33:03]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2016-10-19 13:33:14]

fdoray@chromium.org changed reviewers:
+ pkasting@chromium.org
- juberti@chromium.org

[fdoray, 2016-10-19 13:33:14]

pkasting@: PTAL

[commit-bot: I haz the power, 2016-10-19 13:33:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 14:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 14:20:52]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-10-19 18:07:12]

LGTM

https://codereview.chromium.org/2409083003/diff/20001/components/omnibox/brow...
File components/omnibox/browser/history_url_provider.h (right):

https://codereview.chromium.org/2409083003/diff/20001/components/omnibox/brow...
components/omnibox/browser/history_url_provider.h:112:
base::SequencedTaskRunnerHandle::Get();
Nit: Can we initialize this in the constructor instead for consistency, as
that's where we init these other members?

(This might also allow forward-declaring SequencedTaskRunner instead of
#including a header in this header.)

[fdoray, 2016-10-20 13:50:22]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-10-20 13:50:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2409083003/#ps40001
(title: "CR pkasting")

[commit-bot: I haz the power, 2016-10-20 13:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-10-20 13:50:40]

https://codereview.chromium.org/2409083003/diff/20001/components/omnibox/brow...
File components/omnibox/browser/history_url_provider.h (right):

https://codereview.chromium.org/2409083003/diff/20001/components/omnibox/brow...
components/omnibox/browser/history_url_provider.h:112:
base::SequencedTaskRunnerHandle::Get();
On 2016/10/19 18:07:11, Peter Kasting wrote:
> Nit: Can we initialize this in the constructor instead for consistency, as
> that's where we init these other members?
> 
> (This might also allow forward-declaring SequencedTaskRunner instead of
> #including a header in this header.)

Done.

[commit-bot: I haz the power, 2016-10-20 14:36:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:18:16]

Description was changed from

==========
Remove MessageLoop::current() from history_url_provider.cc

Whenever possible, use Thread/SequencedTaskRunnerHandle::Get() instead
of MessageLoop::current(). Thread/SequencedTaskRunnerHandle::Get() work
within TaskScheduler while MessageLoop::current() doesn't.

Good reasons to use MessageLoop::current():
- Add destruction, nesting or task observers.
- Run nested loops.

Bad reasons to use MessageLoop::current():
- Post tasks. Use Thread/SequencedTaskRunnerHandle::Get() instead.
- Watch a file descriptor. Use FileDescriptorWatcher instead.
- Verify that it is possible to post tasks to the current thread.
  Use Thread/SequencedTaskRunnerHandle::IsSet() instead.
- Verify that code runs on a specific thread. Use
  SingleThreadTaskRunner::BelongsToCurrentThread() instead.

BUG=650723
==========

to

==========
Remove MessageLoop::current() from history_url_provider.cc

Whenever possible, use Thread/SequencedTaskRunnerHandle::Get() instead
of MessageLoop::current(). Thread/SequencedTaskRunnerHandle::Get() work
within TaskScheduler while MessageLoop::current() doesn't.

Good reasons to use MessageLoop::current():
- Add destruction, nesting or task observers.
- Run nested loops.

Bad reasons to use MessageLoop::current():
- Post tasks. Use Thread/SequencedTaskRunnerHandle::Get() instead.
- Watch a file descriptor. Use FileDescriptorWatcher instead.
- Verify that it is possible to post tasks to the current thread.
  Use Thread/SequencedTaskRunnerHandle::IsSet() instead.
- Verify that code runs on a specific thread. Use
  SingleThreadTaskRunner::BelongsToCurrentThread() instead.

BUG=650723

Committed: https://crrev.com/5686c9eb004698df3b62f4e3d63e1ceaca0eff4e
Cr-Commit-Position: refs/heads/master@{#426474}
==========

[commit-bot: I haz the power, 2016-10-21 13:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/5686c9eb004698df3b62f4e3d63e1ceaca0eff4e
Cr-Commit-Position: refs/heads/master@{#426474}