chromeos: Fix display failures when going to mirrored mode.

chromeos: Fix display failures when going to mirrored mode.

This fixes an issue where mirrored mode configuration would
fail when the internal and external displays didn't share a
common resolution. A new mode would be created on the
internal display, but it wasn't added to the corresponding
OutputSnapshot struct, resulting in a later failure.

It also moves the mirror-mode-finding code from
RealOutputConfiguratorDelegate to OutputConfigurator so it
can be tested.

BUG=289159
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223642

[oshima, 2013-09-17 15:22:13]

lgtm with nits.

+yuly to double check panel fitting code.

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
File chromeos/display/output_configurator.h (right):

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
chromeos/display/output_configurator.h:373: // |try_creating| allows creating a
panel-fitting mode for |internal_output|
nit: isn't it better to call this |try_panel_fitting| instead of |try_creating|?

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/real_outp...
File chromeos/display/real_output_configurator_delegate.h (right):

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/real_outp...
chromeos/display/real_output_configurator_delegate.h:63: float* refresh_rate);
Maybe this should pass ModeInfo* instead?

[Daniel Erat, 2013-09-17 15:53:27]

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
chromeos/display/output_configurator.cc:574:
internal_output->mode_infos.insert(std::make_pair(mode, external_info));
(Side note: Apart from this line, which is the actual bug fix, I haven't made
any intentional changes to this method, apart from changing it to operate on
OutputSnapshots instead of using Xlib structures.)

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
File chromeos/display/output_configurator.h (right):

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/output_co...
chromeos/display/output_configurator.h:373: // |try_creating| allows creating a
panel-fitting mode for |internal_output|
On 2013/09/17 15:22:14, oshima wrote:
> nit: isn't it better to call this |try_panel_fitting| instead of
|try_creating|?

Sure, done. (Also renamed the method to FindMirrorMode().)

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/real_outp...
File chromeos/display/real_output_configurator_delegate.h (right):

https://codereview.chromium.org/24081004/diff/8001/chromeos/display/real_outp...
chromeos/display/real_output_configurator_delegate.h:63: float* refresh_rate);
On 2013/09/17 15:22:14, oshima wrote:
> Maybe this should pass ModeInfo* instead?

Done.

[ynovikov, 2013-09-17 16:01:16]

lgtm

[commit-bot: I haz the power, 2013-09-17 16:02:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/24081004/19001

[commit-bot: I haz the power, 2013-09-17 16:16:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/24081004/41001

[commit-bot: I haz the power, 2013-09-17 18:30:37]

Change committed as 223642