Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 24079010: gpu: Upgrade DEPTH_COMPONENT16 to DEPTH_COMPONENT24 if possible (Closed)

Created:
7 years, 3 months ago by Sami
Modified:
7 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium, alokp
Visibility:
Public.

Description

gpu: Upgrade DEPTH_COMPONENT16 to DEPTH_COMPONENT24 if possible Upgrade the DEPTH_COMPONENT16 render buffer storage format to DEPTH_COMPONENT24 if the GLES implementation supports the OES_depth24 extension. This is done to improve content portability between desktop and mobile, since we already do a similar mapping from DEPTH_COMPONENT16 to the unsized DEPTH_COMPONENT on desktop GL. This means that for example WebGL content can end up relying on a higher precision depth buffer even though it only requested DEPTH_COMPONENT16. BUG=285400 TEST=http://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html on Nexus 4 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224509

Patch Set 1 #

Patch Set 2 : Fix failing unit test by restoring previous GL implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -49 lines) Patch
gpu/command_buffer/service/context_group.cc View 1 chunk +4 lines, -1 line 0 comments Download
gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
gpu/command_buffer/service/feature_info.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
gpu/command_buffer/service/framebuffer_manager_unittest.cc View 4 chunks +13 lines, -22 lines 0 comments Download
gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 5 chunks +14 lines, -11 lines 0 comments Download
gpu/command_buffer/service/renderbuffer_manager.h View 3 chunks +9 lines, -4 lines 0 comments Download
gpu/command_buffer/service/renderbuffer_manager.cc View 5 chunks +14 lines, -5 lines 0 comments Download
gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 1 6 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sami
7 years, 3 months ago (2013-09-18 12:57:35 UTC) #1
Ken Russell (switch to Gerrit)
Nice work. LGTM Sorry about the failures on the GPU try bots. We think we've ...
7 years, 3 months ago (2013-09-18 23:46:55 UTC) #2
bajones
LGTM too.
7 years, 3 months ago (2013-09-18 23:56:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/24079010/1
7 years, 3 months ago (2013-09-19 10:06:43 UTC) #4
commit-bot: I haz the power
Change committed as 224117
7 years, 3 months ago (2013-09-19 13:04:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/24079010/26001
7 years, 3 months ago (2013-09-20 17:32:09 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 22:50:39 UTC) #7
Message was sent while issue was closed.
Change committed as 224509

Powered by Google App Engine
This is Rietveld 408576698