Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 24076010: Add 'requests' library to third_party. (Closed)

Created:
7 years, 3 months ago by Vadim Sh.
Modified:
7 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Add 'requests' library to third_party. BUG=288028 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222845

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17823 lines, --1 lines) Patch
A third_party/requests/HISTORY.rst View 1 chunk +659 lines, -0 lines 0 comments Download
A third_party/requests/LICENSE View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/requests/NOTICE View 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/requests/README.rst View 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/requests/README.swarming View 1 chunk +12 lines, -0 lines 1 comment Download
A third_party/requests/__init__.py View 1 chunk +77 lines, -0 lines 1 comment Download
A third_party/requests/adapters.py View 1 chunk +342 lines, -0 lines 1 comment Download
A third_party/requests/api.py View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/requests/auth.py View 1 chunk +177 lines, -0 lines 0 comments Download
A third_party/requests/cacert.pem View 1 chunk +3290 lines, -0 lines 0 comments Download
A third_party/requests/certs.py View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/requests/compat.py View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/requests/cookies.py View 1 chunk +389 lines, -0 lines 0 comments Download
A third_party/requests/exceptions.py View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/requests/hooks.py View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/requests/models.py View 1 chunk +686 lines, -0 lines 0 comments Download
A third_party/requests/packages/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/__init__.py View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/big5freq.py View 1 chunk +925 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/big5prober.py View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/chardistribution.py View 1 chunk +231 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/charsetgroupprober.py View 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/charsetprober.py View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/codingstatemachine.py View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/compat.py View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/constants.py View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/cp949prober.py View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/escprober.py View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/escsm.py View 1 chunk +242 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/eucjpprober.py View 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/euckrfreq.py View 1 chunk +596 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/euckrprober.py View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/euctwfreq.py View 1 chunk +428 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/euctwprober.py View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/gb2312freq.py View 1 chunk +472 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/gb2312prober.py View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/hebrewprober.py View 1 chunk +283 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/jisfreq.py View 1 chunk +569 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/jpcntx.py View 1 chunk +219 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langbulgarianmodel.py View 1 chunk +229 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langcyrillicmodel.py View 1 chunk +329 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langgreekmodel.py View 1 chunk +225 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langhebrewmodel.py View 1 chunk +201 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langhungarianmodel.py View 1 chunk +225 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/langthaimodel.py View 1 chunk +200 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/latin1prober.py View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/mbcharsetprober.py View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/mbcsgroupprober.py View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/mbcssm.py View 1 chunk +575 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/sbcharsetprober.py View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/sbcsgroupprober.py View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/sjisprober.py View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/universaldetector.py View 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/requests/packages/charade/utf8prober.py View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/__init__.py View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/_collections.py View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/connectionpool.py View 1 chunk +597 lines, -0 lines 0 comments Download
A + third_party/requests/packages/urllib3/contrib/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/requests/packages/urllib3/contrib/ntlmpool.py View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/contrib/pyopenssl.py View 1 chunk +167 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/exceptions.py View 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/filepost.py View 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/packages/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/packages/ordered_dict.py View 1 chunk +260 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/packages/six.py View 1 chunk +385 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/packages/ssl_match_hostname/__init__.py View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/poolmanager.py View 1 chunk +192 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/request.py View 1 chunk +142 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/response.py View 1 chunk +241 lines, -0 lines 0 comments Download
A third_party/requests/packages/urllib3/util.py View 1 chunk +378 lines, -0 lines 0 comments Download
A third_party/requests/sessions.py View 1 chunk +501 lines, -0 lines 0 comments Download
A third_party/requests/status_codes.py View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/requests/structures.py View 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/requests/utils.py View 1 chunk +550 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Vadim Sh.
I'm adding third_party/requests first to make a CL that actually uses it more readable. https://codereview.chromium.org/24076010/diff/1/third_party/requests/README.swarming ...
7 years, 3 months ago (2013-09-12 16:24:02 UTC) #1
M-A Ruel
Please move everything in third_party/requests/packages/ to third_party/. https://codereview.chromium.org/24076010/diff/1/third_party/requests/__init__.py File third_party/requests/__init__.py (right): https://codereview.chromium.org/24076010/diff/1/third_party/requests/__init__.py#newcode40 third_party/requests/__init__.py:40: :license: Apache ...
7 years, 3 months ago (2013-09-12 16:28:00 UTC) #2
Vadim Sh.
On 2013/09/12 16:28:00, M-A Ruel wrote: > Please move everything in third_party/requests/packages/ to third_party/. > ...
7 years, 3 months ago (2013-09-12 16:35:07 UTC) #3
M-A Ruel
On 2013/09/12 16:35:07, Vadim Sh. wrote: > On 2013/09/12 16:28:00, M-A Ruel wrote: > > ...
7 years, 3 months ago (2013-09-12 16:43:07 UTC) #4
Vadim Sh.
On 2013/09/12 16:43:07, M-A Ruel wrote: > On 2013/09/12 16:35:07, Vadim Sh. wrote: > > ...
7 years, 3 months ago (2013-09-12 16:54:55 UTC) #5
Vadim Sh.
On 2013/09/12 16:54:55, Vadim Sh. wrote: > On 2013/09/12 16:43:07, M-A Ruel wrote: > > ...
7 years, 3 months ago (2013-09-12 16:56:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/24076010/1
7 years, 3 months ago (2013-09-12 16:56:36 UTC) #7
commit-bot: I haz the power
Presubmit check for 24076010-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 3 months ago (2013-09-12 17:12:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/24076010/1
7 years, 3 months ago (2013-09-12 17:34:54 UTC) #9
commit-bot: I haz the power
Presubmit check for 24076010-1 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 3 months ago (2013-09-12 17:50:15 UTC) #10
Vadim Sh.
Ok, Commit Queue, I give up for now.
7 years, 3 months ago (2013-09-12 17:51:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/24076010/1
7 years, 3 months ago (2013-09-12 19:53:12 UTC) #12
commit-bot: I haz the power
Change committed as 222845
7 years, 3 months ago (2013-09-12 20:10:08 UTC) #13
Vadim Sh.
On 2013/09/12 20:10:08, I haz the power (commit-bot) wrote: > Change committed as 222845 Thank ...
7 years, 3 months ago (2013-09-12 20:12:42 UTC) #14
M-A Ruel
On 2013/09/12 20:12:42, Vadim Sh. wrote: > On 2013/09/12 20:10:08, I haz the power (commit-bot) ...
7 years, 3 months ago (2013-09-12 20:19:00 UTC) #15
Vadim Sh.
7 years, 3 months ago (2013-09-12 20:22:46 UTC) #16
Message was sent while issue was closed.
On 2013/09/12 20:19:00, M-A Ruel wrote:
> On 2013/09/12 20:12:42, Vadim Sh. wrote:
> > On 2013/09/12 20:10:08, I haz the power (commit-bot) wrote:
> > > Change committed as 222845
> > 
> > Thank you, Commit Queue, for saving me from figuring out how to setup
git-svn
> > for swarm_client...
> 
> which fails if you used
> https://code.google.com/p/swarming/wiki/GettingTheSources, resulting in:
> http://permalink.gmane.org/gmane.comp.version-control.git/234671

I actually use https://chromium.googlesource.com/a/chromium/tools/swarm_client
mirror for some reason I forgot already... So CQ is a real life-saver for me now
:)

Powered by Google App Engine
This is Rietveld 408576698