Issue 24076002: Disallowing shelf changes via drag & drop if the enterprise profile does not allow changes

Issue 24076002: Disallowing shelf changes via drag & drop if the enterprise profile does not allow changes (Closed)

Created:
7 years, 3 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 3 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disallowing shelf changes via drag & drop if the enterprise profile does not allow changes There is no change allowed to the shelf when the enterprise mode 'locks down' the shelf. BUG=285056 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222173

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -11 lines)			Patch
M	ash/launcher/launcher_delegate.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shell/launcher_delegate_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/shell/launcher_delegate_impl.cc	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	ash/test/test_launcher_delegate.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/test/test_launcher_delegate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Cook

lgtm with one question https://codereview.chromium.org/24076002/diff/1/ash/shell/launcher_delegate_impl.cc File ash/shell/launcher_delegate_impl.cc (right): https://codereview.chromium.org/24076002/diff/1/ash/shell/launcher_delegate_impl.cc#newcode91 ash/shell/launcher_delegate_impl.cc:91: return false; Should this be ...

7 years, 3 months ago (2013-09-09 23:14:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/24076002/1

7 years, 3 months ago (2013-09-09 23:24:15 UTC) #3

Message was sent while issue was closed.

Change committed as 222173

Expand Messages | Collapse Messages