Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tests/standalone/vmservice/isolate_bad_object_test.dart

Issue 24075002: Expose field data, use class id, and merge all collections into "objects" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/vmservice/isolate_bad_object_test.dart
diff --git a/tests/standalone/vmservice/isolate_bad_code_test.dart b/tests/standalone/vmservice/isolate_bad_object_test.dart
similarity index 76%
rename from tests/standalone/vmservice/isolate_bad_code_test.dart
rename to tests/standalone/vmservice/isolate_bad_object_test.dart
index fc6ef6820e8b8166a796f78cebe8a3c3b764d6f4..b7d2ef51a235dc35a1c4410e735149ff31ac5c9b 100644
--- a/tests/standalone/vmservice/isolate_bad_code_test.dart
+++ b/tests/standalone/vmservice/isolate_bad_object_test.dart
@@ -9,8 +9,8 @@ import 'test_helper.dart';
import 'package:expect/expect.dart';
class NullCollectionTest extends VmServiceRequestHelper {
- NullCollectionTest(port, id, collection) :
- super('http://127.0.0.1:$port/isolates/$id/$collection/50');
+ NullCollectionTest(port, id) :
+ super('http://127.0.0.1:$port/isolates/$id/objects/50');
onRequestCompleted(Map reply) {
Expect.equals('null', reply['type']);
@@ -18,8 +18,8 @@ class NullCollectionTest extends VmServiceRequestHelper {
}
class BadCollectionTest extends VmServiceRequestHelper {
- BadCollectionTest(port, id, collection) :
- super('http://127.0.0.1:$port/isolates/$id/$collection');
+ BadCollectionTest(port, id) :
+ super('http://127.0.0.1:$port/isolates/$id/objects');
onRequestCompleted(Map reply) {
Expect.equals('error', reply['type']);
@@ -44,11 +44,9 @@ main() {
var test = new IsolateListTest(port);
test.makeRequest().then((_) {
var badCollectionRequest =
- new BadCollectionTest(port, test._isolateId,
- 'codes').makeRequest();
+ new BadCollectionTest(port, test._isolateId).makeRequest();
var nullCollectionRequest =
- new NullCollectionTest(port, test._isolateId,
- 'codes').makeRequest();
+ new NullCollectionTest(port, test._isolateId).makeRequest();
var requests = Future.wait([badCollectionRequest, nullCollectionRequest]);
requests.then((_) {
process.requestExit();

Powered by Google App Engine
This is Rietveld 408576698