Issue 24072005: [rAC, OSX] Place autofill popups correctly.

Issue 24072005: [rAC, OSX] Place autofill popups correctly. (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16

Modified:
7 years, 3 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[rAC, OSX] Place autofill popups correctly. Autofill suggestions were popping up in the wrong place, due to a bad coordinate system conversion. BUG=286521 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223524

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_section_container.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

Accidentally took view coordinates in parent coordinate system (frame) instead of in view coordinate system ...

7 years, 3 months ago (2013-09-13 01:51:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/24072005/1

7 years, 3 months ago (2013-09-14 03:10:08 UTC) #4

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79015

7 years, 3 months ago (2013-09-14 13:59:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/24072005/1

7 years, 3 months ago (2013-09-17 01:18:20 UTC) #6

Message was sent while issue was closed.

Change committed as 223524

Expand Messages | Collapse Messages