chrome/browser/android/shortcut_helper.h - Issue 24063004: Adding a dialog on click of "add to homescreen" menu item to edit the title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 24063004: Adding a dialog on click of "add to homescreen" menu item to edit the title. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Error uploading patchset, trying again Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | chrome/browser/android/shortcut_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.h

diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h

index 2e66a9cbeee30efccdb300aabe76bf8d89de5f04..302d9d7c1df635f787de243515f6002ccaa6f76b 100644

--- a/chrome/browser/android/shortcut_helper.h

+++ b/chrome/browser/android/shortcut_helper.h

@@ -36,7 +36,7 @@ class GURL;

// the shortcut.

class ShortcutBuilder : public content::WebContentsObserver {

public:

- explicit ShortcutBuilder(content::WebContents* web_contents);

+ explicit ShortcutBuilder(content::WebContents* web_contents, string16 title);

virtual ~ShortcutBuilder() {}

void OnDidRetrieveWebappInformation(bool success,

@@ -65,7 +65,7 @@ class ShortcutHelper {

public:

// Adds a shortcut to the current URL to the Android home screen, firing

// background tasks to pull all the data required.

- static void AddShortcut(content::WebContents* web_contents);

+ static void AddShortcut(content::WebContents* web_contents, string16 title);

// Adds a shortcut to the launcher. Must be called from a WorkerPool task.

static void AddShortcutInBackground(