media/ffmpeg/ffmpeg_common.cc - Issue 2405453002: Fix Integer-overflow in base::Time::FromExploded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/ffmpeg/ffmpeg_common.cc

Issue 2405453002: Fix Integer-overflow in base::Time::FromExploded. (Closed)

Patch Set: rebased and fixed net unittest Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/ffmpeg/ffmpeg_common.cc

diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc

index 8c4a55c953111de0613d6692408f739b541428b5..aaf3afcd5de754f1b2371deb3565ae466d3bd5bb 100644

--- a/media/ffmpeg/ffmpeg_common.cc

+++ b/media/ffmpeg/ffmpeg_common.cc

@@ -753,6 +753,9 @@ bool FFmpegUTCDateToTime(const char* date_utc, base::Time* out) {

base::Time::Exploded exploded;

exploded.millisecond = 0;

+ // This field cannot be uninitialized. Unless not modified, make it 0 here

+ // then.

+ exploded.day_of_week = 0;

if (base::StringToInt(date_fields[0], &exploded.year) &&

base::StringToInt(date_fields[1], &exploded.month) &&

base::StringToInt(date_fields[2], &exploded.day_of_month) &&