Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 240503007: Run `svn cleanup` before every update and reset. (Closed)

Created:
6 years, 8 months ago by ghost stip (do not use)
Modified:
6 years, 8 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Run `svn cleanup` before every update and reset. Testing on a bot with an 'unclean' Chromium checkout: Unpatched `gclient revert -v -v -v --nohooks --upstream` (unclean checkout) real 9m14.280s user 0m37.238s sys 0m37.738s Patched 'gclient revert -v -v -v --nohooks --upstream' (unclean checkout) real 5m50.065s user 1m18.889s sys 0m57.860s ---------------- after patched gclient revert run (cleans the checkout) Unpatched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout) real 0m21.602s user 0m24.966s sys 0m13.969s Patched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout) real 0m27.467s user 0m28.382s sys 0m22.629s BUG=336983 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264753

Patch Set 1 #

Patch Set 2 : Remove spurious check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M gclient_scm.py View 1 2 chunks +9 lines, -12 lines 0 comments Download
M tests/gclient_scm_test.py View 11 chunks +33 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ghost stip (do not use)
This should be the end of crbug.com/336983.
6 years, 8 months ago (2014-04-17 08:59:35 UTC) #1
Dirk Pranke
lgtm
6 years, 8 months ago (2014-04-17 18:21:40 UTC) #2
iannucci
On 2014/04/17 18:21:40, Dirk Pranke wrote: > lgtm Mike, can you verify performance figures for ...
6 years, 8 months ago (2014-04-17 18:25:32 UTC) #3
ghost stip (do not use)
On 2014/04/17 18:25:32, iannucci wrote: > On 2014/04/17 18:21:40, Dirk Pranke wrote: > > lgtm ...
6 years, 8 months ago (2014-04-17 21:35:40 UTC) #4
ghost stip (do not use)
Windows data: Unpatched `gclient.bat revert -v -v -v --nohooks --upstream` with dirty checkout: 2m29s Patched ...
6 years, 8 months ago (2014-04-17 23:22:35 UTC) #5
ghost stip (do not use)
The CQ bit was checked by stip@chromium.org
6 years, 8 months ago (2014-04-18 08:03:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/240503007/20001
6 years, 8 months ago (2014-04-18 08:03:30 UTC) #7
commit-bot: I haz the power
Change committed as 264753
6 years, 8 months ago (2014-04-18 08:05:02 UTC) #8
ghost stip (do not use)
6 years, 8 months ago (2014-04-21 22:16:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://chromiumcodereview.appspot.com/245293003/ by stip@chromium.org.

The reason for reverting is: It's inconclusive if this actually helped the bots,
so reverting..

Powered by Google App Engine
This is Rietveld 408576698