Issue 24048003: [Refactor] Cache the views::Widget* that the FrameMaximizeButton acts on

Issue 24048003: [Refactor] Cache the views::Widget* that the FrameMaximizeButton acts on (Closed)

Created:
7 years, 3 months ago by pkotwicz

Modified:
7 years, 3 months ago

Reviewers:
James Cook, Mr4D (OOO till 08-26)

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cache the views::Widget* instead of the views::NonClientFrameView* that the FrameMaximizeButton acts on BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223422

Patch Set 2 : Nits per jamescook@ #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -70 lines)			Patch
M	ash/wm/caption_buttons/frame_caption_button_container_view.h	View	1	2 chunks	+2 lines, -7 lines	0 comments	Download
M	ash/wm/caption_buttons/frame_caption_button_container_view.cc	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	ash/wm/caption_buttons/frame_caption_button_container_view_unittest.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/wm/caption_buttons/frame_maximize_button.h	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	ash/wm/caption_buttons/frame_maximize_button.cc	View	1	14 chunks	+34 lines, -38 lines	0 comments	Download
M	ash/wm/custom_frame_view_ash.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/frame_painter_unittest.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ash/wm/panels/panel_frame_view.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/app_non_client_frame_view_ash.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

James for OWNERS rubber stamp (Forgot to add jamescook@ as a reviewer the first time)

7 years, 3 months ago (2013-09-16 04:43:06 UTC) #4

James Cook

lgtm with a couple suggestions https://codereview.chromium.org/24048003/diff/1/ash/wm/caption_buttons/frame_caption_button_container_view.h File ash/wm/caption_buttons/frame_caption_button_container_view.h (right): https://codereview.chromium.org/24048003/diff/1/ash/wm/caption_buttons/frame_caption_button_container_view.h#newcode47 ash/wm/caption_buttons/frame_caption_button_container_view.h:47: // |frame_view| and |frame| ...

7 years, 3 months ago (2013-09-16 16:08:07 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/24048003/10001

7 years, 3 months ago (2013-09-16 18:02:02 UTC) #6

Message was sent while issue was closed.

Change committed as 223422

Expand Messages | Collapse Messages