Issue 24042002: Changing the --enable-sctp-data-channels flag to --disable-sctp-data-channels so that SCTP is turned

Issue 24042002: Changing the --enable-sctp-data-channels flag to --disable-sctp-data-channels so that SCTP is turned (Closed)

Created:
7 years, 3 months ago by jiayl

Modified:
7 years, 3 months ago

Reviewers:
tommi (sloooow) - chröme, sky, Jói, juberti2

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, juberti2, ldixon, Lally Singh

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Changing the --enable-sctp-data-channels flag to --disable-sctp-data-channels so that SCTP is turned on by default. BUG=248486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221872

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -18 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/media/rtc_peer_connection_handler.cc	View	1 2 3	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

jiayl

joi: need your approval for content/public/ sky: need your approval for content/browser/ and chrome/ tommi: ...

7 years, 3 months ago (2013-09-06 17:25:37 UTC) #1

jiayl

Reviewers, we hope to land this today so that we'll have 2 weeks baking time ...

7 years, 3 months ago (2013-09-06 20:31:47 UTC) #3

juberti2

lgtm Instead of completely removing the flag, consider changing the flag from an enable flag ...

7 years, 3 months ago (2013-09-06 20:50:02 UTC) #5

jiayl

Changed the flag to --disable-sctp-data-channels instead of removing it. PTAL!

7 years, 3 months ago (2013-09-06 21:17:36 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/24042002/15001

7 years, 3 months ago (2013-09-07 00:37:17 UTC) #10

Message was sent while issue was closed.

Change committed as 221872

Expand Messages | Collapse Messages