Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: components/autofill/core/browser/autofill_assistant_unittest.cc

Issue 2403773002: Remove stl_util's STLDeleteContainerPointers from autofill. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_assistant_unittest.cc
diff --git a/components/autofill/core/browser/autofill_assistant_unittest.cc b/components/autofill/core/browser/autofill_assistant_unittest.cc
index fa48977735b43c653b8f59268c00737bf7578a8a..4e972773b1628d119ffc05f133105a0a4cf4a4d1 100644
--- a/components/autofill/core/browser/autofill_assistant_unittest.cc
+++ b/components/autofill/core/browser/autofill_assistant_unittest.cc
@@ -125,7 +125,8 @@ MATCHER_P(CreditCardMatches, guid, "") {
TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOff) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
@@ -135,11 +136,11 @@ TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn) {
EnableAutofillCreditCardAssist();
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
- std::vector<FormStructure*> form_structures;
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// With valid input, the function extracts the credit card form properly.
- form_structures.push_back(form_structure.get());
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
@@ -157,8 +158,8 @@ TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn_NotSecure) {
std::unique_ptr<FormStructure> form_structure(new FormStructure(form));
form_structure->DetermineHeuristicTypes();
- std::vector<FormStructure*> form_structures;
- form_structures.push_back(form_structure.get());
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
@@ -168,8 +169,8 @@ TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn_NotSecure) {
std::unique_ptr<FormStructure> form_structure(new FormStructure(form));
form_structure->DetermineHeuristicTypes();
- std::vector<FormStructure*> form_structures;
- form_structures.push_back(form_structure.get());
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
}
@@ -179,7 +180,8 @@ TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_CancelCvc) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
// Will extract the credit card form data.
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// Create a valid card for the assist.
@@ -200,7 +202,8 @@ TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_SubmitCvc) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
// Will extract the credit card form data.
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// Create a valid card for the assist.
« no previous file with comments | « components/autofill/core/browser/autofill_assistant.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698