Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/password_manager/password_store_win.cc

Issue 2403773002: Remove stl_util's STLDeleteContainerPointers from autofill. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_win.cc
diff --git a/chrome/browser/password_manager/password_store_win.cc b/chrome/browser/password_manager/password_store_win.cc
index 2625234a0586d26b186e6e9aba1096c79666c4c5..252b270017a3ddae68e614362eb9b8c3ae6d9390 100644
--- a/chrome/browser/password_manager/password_store_win.cc
+++ b/chrome/browser/password_manager/password_store_win.cc
@@ -70,7 +70,7 @@ class PasswordStoreWin::DBHandler : public WebDataServiceConsumer {
// WebDataServiceConsumer implementation.
void OnWebDataServiceRequestDone(
PasswordWebDataService::Handle handle,
- const WDTypedResult* result) override;
+ std::unique_ptr<WDTypedResult> result) override;
scoped_refptr<PasswordWebDataService> web_data_service_;
@@ -146,7 +146,7 @@ PasswordStoreWin::DBHandler::GetIE7Results(
void PasswordStoreWin::DBHandler::OnWebDataServiceRequestDone(
PasswordWebDataService::Handle handle,
- const WDTypedResult* result) {
+ std::unique_ptr<WDTypedResult> result) {
// TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
// fixed.
tracked_objects::ScopedTracker tracking_profile(
@@ -170,7 +170,7 @@ void PasswordStoreWin::DBHandler::OnWebDataServiceRequestDone(
}
DCHECK_EQ(PASSWORD_IE7_RESULT, result->GetType());
- result_callback.Run(GetIE7Results(result, *form));
+ result_callback.Run(GetIE7Results(result.get(), *form));
}
PasswordStoreWin::PasswordStoreWin(
« no previous file with comments | « chrome/browser/autofill/form_structure_browsertest.cc ('k') | chrome/browser/password_manager/password_store_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698