Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 24037004: chrome: Wrap correctly what is X11 theming code (Closed)

Created:
7 years, 3 months ago by vignatti (out of this project)
Modified:
7 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, kalyank, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

chrome: Wrap correctly what is X11 theming code So other Aura platforms can use also this file, in particular for the Chrome target under Ozone. BUG=295089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/themes/theme_service_factory.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
lgtm
7 years, 3 months ago (2013-09-22 06:05:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/24037004/1
7 years, 3 months ago (2013-09-23 13:10:35 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-23 15:11:44 UTC) #3
vignatti (out of this project)
On 2013/09/23 15:11:44, I haz the power (commit-bot) wrote: > Step "update" is always a ...
7 years, 3 months ago (2013-09-23 18:05:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/24037004/1
7 years, 3 months ago (2013-09-23 18:06:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=201275
7 years, 3 months ago (2013-09-23 22:26:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/24037004/1
7 years, 3 months ago (2013-09-24 13:38:07 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 15:57:39 UTC) #8
Message was sent while issue was closed.
Change committed as 224996

Powered by Google App Engine
This is Rietveld 408576698