components/omnibox/browser/physical_web_provider.cc - Issue 2403423005: Expose Physical Web metadata to native clients over JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/physical_web_provider.cc

Issue 2403423005: Expose Physical Web metadata to native clients over JNI (Closed)

Patch Set: remove unit test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/physical_web_provider.cc

diff --git a/components/omnibox/browser/physical_web_provider.cc b/components/omnibox/browser/physical_web_provider.cc

index e0e326f9d36eb24aff1a7b33548ab0f8e1aaeaed..363b4264d6f891b2d03bae171a24a1ef2462fc0b 100644

--- a/components/omnibox/browser/physical_web_provider.cc

+++ b/components/omnibox/browser/physical_web_provider.cc

@@ -106,8 +106,8 @@ void PhysicalWebProvider::ConstructMatches(base::ListValue* metadata_list) {

std::string url_string;

std::string title_string;

- if (!metadata_item->GetString("resolvedUrl", &url_string) ||

- !metadata_item->GetString("title", &title_string)) {

+ if (!metadata_item->GetString(kPhysicalWebResolvedUrlKey, &url_string) ||

+ !metadata_item->GetString(kPhysicalWebTitleKey, &title_string)) {

continue;

}

base::string16 title =