Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 24031007: RenderGrid should include grid items' margins in its intrinsic size (Closed)

Created:
7 years, 3 months ago by Julien - ping for review
Modified:
7 years, 3 months ago
Reviewers:
tony, ojan, eseidel
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, eseidel
Visibility:
Public.

Description

RenderGrid should include grid items' margins in its intrinsic size To match flexbox and the author's intent, the grid element's intrinsic logical widths should account for the fixed margins on any grid items'. The change is straightforward and moves the code from RenderFlexibleBox to RenderBlock for easy sharing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -24 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html View 2 chunks +30 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
7 years, 3 months ago (2013-09-19 16:48:08 UTC) #1
eseidel
lgtm
7 years, 3 months ago (2013-09-19 16:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/24031007/1
7 years, 3 months ago (2013-09-19 16:53:43 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 18:16:11 UTC) #4
Message was sent while issue was closed.
Change committed as 158041

Powered by Google App Engine
This is Rietveld 408576698