Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: Source/core/page/ConsoleBase.idl

Issue 24027002: DevTools: implement console.timeline/timelineEnd. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/ConsoleBase.idl
diff --git a/Source/core/page/ConsoleBase.idl b/Source/core/page/ConsoleBase.idl
index e830b9bb4f4630d12dd1c6f4a60d68ff61fe1335..542610fd162306a99066bb6a2deb77c3be49fd3d 100644
--- a/Source/core/page/ConsoleBase.idl
+++ b/Source/core/page/ConsoleBase.idl
@@ -43,14 +43,18 @@
[CallWith=ScriptArguments&ScriptState] void trace();
[CallWith=ScriptArguments&ScriptState, ImplementedAs=assertCondition] void assert([Default=Undefined] optional boolean condition);
[CallWith=ScriptArguments&ScriptState] void count();
- [DeprecateAs=ConsoleMarkTimeline, CallWith=ScriptArguments] void markTimeline();
+ [DeprecateAs=ConsoleMarkTimeline] void markTimeline([Default=NullString] optional DOMString title);
[CallWith=ScriptState] void profile([Default=NullString] optional DOMString title);
[CallWith=ScriptState] void profileEnd([Default=NullString] optional DOMString title);
- void time([TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
- [CallWith=ScriptState] void timeEnd([TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
- [CallWith=ScriptArguments] void timeStamp();
+ void time([Default=NullString] optional DOMString title);
+ [CallWith=ScriptState] void timeEnd([Default=NullString] optional DOMString title);
+ void timeStamp([Default=NullString] optional DOMString title);
+
+ [CallWith=ScriptState] void timeline([Default=NullString] optional DOMString title);
+ [CallWith=ScriptState] void timelineEnd([Default=NullString] optional DOMString title);
+
[CallWith=ScriptArguments&ScriptState] void group();
[CallWith=ScriptArguments&ScriptState] void groupCollapsed();
void groupEnd();

Powered by Google App Engine
This is Rietveld 408576698