Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: media/blink/webcontentdecryptionmodule_impl.h

Issue 2402563002: Keep reference to CDM to avoid it's premature destruction (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/cdm_session_adapter.cc ('k') | media/blink/webcontentdecryptionmodule_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webcontentdecryptionmodule_impl.h
diff --git a/media/blink/webcontentdecryptionmodule_impl.h b/media/blink/webcontentdecryptionmodule_impl.h
index 989b4a08cbeee174e81460227a4a5a09f731b6fc..5425e95d8b1061ec1624ead05b9c51bbab1c93d6 100644
--- a/media/blink/webcontentdecryptionmodule_impl.h
+++ b/media/blink/webcontentdecryptionmodule_impl.h
@@ -27,9 +27,9 @@ class WebSecurityOrigin;
namespace media {
struct CdmConfig;
-class CdmContext;
class CdmFactory;
class CdmSessionAdapter;
+class MediaKeys;
class WebContentDecryptionModuleSessionImpl;
class MEDIA_BLINK_EXPORT WebContentDecryptionModuleImpl
@@ -52,10 +52,8 @@ class MEDIA_BLINK_EXPORT WebContentDecryptionModuleImpl
size_t server_certificate_length,
blink::WebContentDecryptionModuleResult result) override;
- // Returns the CdmContext associated with this CDM, which must not be nullptr.
- // TODO(jrummell): Figure out lifetimes, as WMPI may still use the decryptor
- // after WebContentDecryptionModule is freed. http://crbug.com/330324
- CdmContext* GetCdmContext();
+ // Returns a reference to the CDM used by |adapter_|.
+ scoped_refptr<MediaKeys> GetCdm();
private:
friend CdmSessionAdapter;
« no previous file with comments | « media/blink/cdm_session_adapter.cc ('k') | media/blink/webcontentdecryptionmodule_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698