Translate: element API callback interface change

Translate: element API callback interface change

The progress callback interface will be changed as the third parameter
goes to number from boolean. This change make translate.js support
both boolean and number for API migration. Once this change goes to stable
channel, server side library will change to return number to specify error code.

BUG=211308
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221992

[Takashi Toyoshima, 2013-09-06 12:16:22]

Hi, can you take a look on chrome/browser/resources ?
I want to prepare coming server side API update.

[xiyuan, 2013-09-06 16:16:41]

chrome/browser/resources/* LGTM

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
File chrome/browser/resources/translate.js (right):

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:10: var cr = {};
nit: cr = cr || {};

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:31: * to modify the definition.
nit: @const

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:33: var error = {
nit: error -> ERROR for const var name.

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:46: * See also go/dom_translator.js in
google3.
nit: @const

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:48: var mapTranslateErrorToErrorCode = {
nit: mapTranslateErrorToErrorCode -> TRANSLATE_ERROR_TO_ERROR_CODE_MAP

Upper case with '_" for const name and var name should be noun.

[Takashi Toyoshima, 2013-09-09 04:02:29]

Thanks.

Hajime, can you take a look on translate/ ?

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
File chrome/browser/resources/translate.js (right):

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:10: var cr = {};
This script is injected into the new isolated world. So we have a confidence
that cr is not defined here.
But, anyway I follow your suggestion now.

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:31: * to modify the definition.
On 2013/09/06 16:16:41, xiyuan wrote:
> nit: @const

Done.

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:33: var error = {
On 2013/09/06 16:16:41, xiyuan wrote:
> nit: error -> ERROR for const var name.

Done.

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:46: * See also go/dom_translator.js in
google3.
On 2013/09/06 16:16:41, xiyuan wrote:
> nit: @const

Done.

https://chromiumcodereview.appspot.com/24024004/diff/10001/chrome/browser/res...
chrome/browser/resources/translate.js:48: var mapTranslateErrorToErrorCode = {
On 2013/09/06 16:16:41, xiyuan wrote:
> nit: mapTranslateErrorToErrorCode -> TRANSLATE_ERROR_TO_ERROR_CODE_MAP
> 
> Upper case with '_" for const name and var name should be noun.

Done.

[hajimehoshi, 2013-09-09 04:13:50]

lgtm

[commit-bot: I haz the power, 2013-09-09 04:46:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/24024004/18001

[commit-bot: I haz the power, 2013-09-09 08:02:38]

Change committed as 221992