Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 24024003: Implements CPU measurement of a WebRTC call on Mac. (Closed)

Created:
7 years, 3 months ago by phoglund_chromium
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Implements CPU measurement of a WebRTC call on Mac. There's special Mach port magic required to measure CPU on a process other than the current process. Since we want to measure both the renderer and browser process CPU we need to do this. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222045

Patch Set 1 #

Patch Set 2 : Dummy solution for renderer process on mac. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
phoglund_chromium
jam, tommi, please have a look. I needed to hack a DEPS file to get ...
7 years, 3 months ago (2013-09-06 07:19:09 UTC) #1
tommi (sloooow) - chröme
Yes I think moving to content would be the right thing to do.
7 years, 3 months ago (2013-09-06 07:45:05 UTC) #2
phoglund_chromium
Ok, I put in a stopgap for now which will report incorrect values for mac, ...
7 years, 3 months ago (2013-09-06 09:02:45 UTC) #3
tommi (sloooow) - chröme
sgtm lgtm
7 years, 3 months ago (2013-09-06 11:22:04 UTC) #4
jam
(removing myself as a reviewer since tommi is an owner)
7 years, 3 months ago (2013-09-06 16:24:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/24024003/7001
7 years, 3 months ago (2013-09-09 11:10:25 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 16:47:21 UTC) #7
Message was sent while issue was closed.
Change committed as 222045

Powered by Google App Engine
This is Rietveld 408576698