Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24023007: Fix wrong width of Range in vertical text (Closed)

Created:
7 years, 3 months ago by Xianzhu
Modified:
7 years, 2 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix wrong width of Range in vertical text When the original code adjusts the width of the quad of a seleciton box containing one or several characters in vertical text, box->logicalWidth() (which is actually the height of the box) is used. Should use box->width() instead. The original fast/dom/Range/getClientRects.html tests only the whole block selection case, not covering bug 297808. BUG=297808 TEST=fast/dom/Range/getClientRects-character.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158301

Patch Set 1 #

Patch Set 2 : Remove extra fprintf #

Total comments: 9

Patch Set 3 : DOCTYPE etc. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
A LayoutTests/fast/dom/Range/getClientRects-character.html View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Range/getClientRects-character-expected.txt View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
7 years, 3 months ago (2013-09-24 21:06:29 UTC) #1
eae
https://codereview.chromium.org/24023007/diff/6001/Source/core/rendering/RenderText.cpp File Source/core/rendering/RenderText.cpp (right): https://codereview.chromium.org/24023007/diff/6001/Source/core/rendering/RenderText.cpp#newcode333 Source/core/rendering/RenderText.cpp:333: r.setHeight(box->height()); How about removing the branching on isHorizontal and ...
7 years, 3 months ago (2013-09-24 23:14:24 UTC) #2
Xianzhu
https://codereview.chromium.org/24023007/diff/6001/Source/core/rendering/RenderText.cpp File Source/core/rendering/RenderText.cpp (right): https://codereview.chromium.org/24023007/diff/6001/Source/core/rendering/RenderText.cpp#newcode333 Source/core/rendering/RenderText.cpp:333: r.setHeight(box->height()); On 2013/09/24 23:14:25, eae wrote: > How about ...
7 years, 3 months ago (2013-09-24 23:16:43 UTC) #3
eae
https://codereview.chromium.org/24023007/diff/6001/LayoutTests/fast/dom/Range/getClientRects-character.html File LayoutTests/fast/dom/Range/getClientRects-character.html (right): https://codereview.chromium.org/24023007/diff/6001/LayoutTests/fast/dom/Range/getClientRects-character.html#newcode1 LayoutTests/fast/dom/Range/getClientRects-character.html:1: <script src="../../js/resources/js-test-pre.js"></script> Please add a doctype declaration so that ...
7 years, 3 months ago (2013-09-24 23:19:29 UTC) #4
Xianzhu
https://codereview.chromium.org/24023007/diff/6001/LayoutTests/fast/dom/Range/getClientRects-character.html File LayoutTests/fast/dom/Range/getClientRects-character.html (right): https://codereview.chromium.org/24023007/diff/6001/LayoutTests/fast/dom/Range/getClientRects-character.html#newcode1 LayoutTests/fast/dom/Range/getClientRects-character.html:1: <script src="../../js/resources/js-test-pre.js"></script> On 2013/09/24 23:19:30, eae wrote: > Please ...
7 years, 3 months ago (2013-09-24 23:30:03 UTC) #5
eae
LGTM > Tried to remove this, but the result will miss the following lines: > ...
7 years, 3 months ago (2013-09-24 23:36:02 UTC) #6
Xianzhu
On 2013/09/24 23:36:02, eae wrote: > LGTM > > > Tried to remove this, but ...
7 years, 3 months ago (2013-09-24 23:51:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/24023007/19001
7 years, 3 months ago (2013-09-24 23:51:59 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-09-25 07:07:44 UTC) #9
Message was sent while issue was closed. 
Change committed as 158301

Powered by Google App Engine
This is Rietveld 408576698