Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/browser/value_store/value_store_unittest.cc

Issue 24021002: Propagate more information about ValueStore errors to callers, notably an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add Pass*() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/value_store/value_store_unittest.cc
diff --git a/chrome/browser/value_store/value_store_unittest.cc b/chrome/browser/value_store/value_store_unittest.cc
index d45f647891f7811bc3cbf17d90618a7e7daf6a11..0e8847cf7b20e4b2b744aed633e0e8241149ad4f 100644
--- a/chrome/browser/value_store/value_store_unittest.cc
+++ b/chrome/browser/value_store/value_store_unittest.cc
@@ -56,11 +56,11 @@ testing::AssertionResult SettingsEq(
ValueStore::ReadResult actual_result) {
if (actual_result->HasError()) {
return testing::AssertionFailure() <<
- "Result has error: " << actual_result->error();
+ "Result has error: " << actual_result->error().message;
}
std::string error;
- if (!ValuesEqual(&expected, actual_result->settings().get(), &error)) {
+ if (!ValuesEqual(&expected, &actual_result->settings(), &error)) {
return testing::AssertionFailure() << error;
}
@@ -75,7 +75,7 @@ testing::AssertionResult ChangesEq(
ValueStore::WriteResult actual_result) {
if (actual_result->HasError()) {
return testing::AssertionFailure() <<
- "Result has error: " << actual_result->error();
+ "Result has error: " << actual_result->error().message;
}
const ValueStoreChangeList& actual = actual_result->changes();
« no previous file with comments | « chrome/browser/value_store/value_store_frontend_unittest.cc ('k') | chrome/browser/value_store/value_store_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698