Propagate more information about ValueStore errors to callers, notably an

chrome/browser/extensions/api/storage/settings_quota_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_writer.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/storage/settings_backend.h"
 #include "chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h"
@@ skipping 44 matching lines @@
       size_t quota_bytes, size_t quota_bytes_per_item, size_t max_items) {
     ASSERT_TRUE(storage_.get() == NULL);
     SettingsStorageQuotaEnforcer::Limits limits =
         { quota_bytes, quota_bytes_per_item, max_items };
     storage_.reset(new SettingsStorageQuotaEnforcer(limits, delegate_));
   }
 
   // Returns whether the settings in |storage_| and |delegate_| are the same as
   // |settings|.
   bool SettingsEqual(const DictionaryValue& settings) {
-    return settings.Equals(storage_->Get()->settings().get()) &&
-           settings.Equals(delegate_->Get()->settings().get());
+    return settings.Equals(&storage_->Get()->settings()) &&
+           settings.Equals(&delegate_->Get()->settings());
   }
 
   // Values with different serialized sizes.
   scoped_ptr<Value> byte_value_1_;
   scoped_ptr<Value> byte_value_16_;
   scoped_ptr<ListValue> byte_value_256_;
 
   // Quota enforcing storage area being tested.
   scoped_ptr<SettingsStorageQuotaEnforcer> storage_;
 
@@ skipping 512 matching lines @@
 
   storage_->Set(DEFAULTS, "c", *byte_value_1_);
 
   EXPECT_EQ(6u, storage_->GetBytesInUse());
   EXPECT_EQ(2u, storage_->GetBytesInUse("a"));
   EXPECT_EQ(2u, storage_->GetBytesInUse("b"));
   EXPECT_EQ(4u, storage_->GetBytesInUse(ab));
 }
 
 }  // namespace extensions