Propagate more information about ValueStore errors to callers, notably an

chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/policy_value_store.h"
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
@@ skipping 110 matching lines @@
   policy::PolicyMap policies;
   base::FundamentalValue expected(123);
   policies.Set("must", policy::POLICY_LEVEL_MANDATORY,
                policy::POLICY_SCOPE_USER, expected.DeepCopy(), NULL);
   policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,
                policy::POLICY_SCOPE_USER,
                new base::FundamentalValue(456), NULL);
   store_->SetCurrentPolicy(policies, false);
   ValueStore::ReadResult result = store_->Get();
   ASSERT_FALSE(result->HasError());
-  EXPECT_EQ(1u, result->settings()->size());
+  EXPECT_EQ(1u, result->settings().size());
   base::Value* value = NULL;
-  EXPECT_FALSE(result->settings()->Get("may", &value));
-  EXPECT_TRUE(result->settings()->Get("must", &value));
+  EXPECT_FALSE(result->settings().Get("may", &value));
+  EXPECT_TRUE(result->settings().Get("must", &value));
   EXPECT_TRUE(base::Value::Equals(&expected, value));
 }
 
 TEST_F(PolicyValueStoreTest, ReadOnly) {
   ValueStore::WriteOptions options = ValueStore::DEFAULTS;
 
   base::StringValue string_value("value");
   EXPECT_TRUE(store_->Set(options, "key", string_value)->HasError());
 
   base::DictionaryValue dict;
@@ skipping 66 matching lines @@
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Don't notify when there aren't changes.
   EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
   store_->SetCurrentPolicy(policies, true);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 }  // namespace extensions