Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/drag-and-drop-thresholds.html

Issue 2401503002: Align drag threshold across content types. (Closed)
Patch Set: Addressed nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/MouseEventManager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <!DOCTYPE html>
2 <script src="../../resources/testharness.js"></script>
3 <script src="../../resources/testharnessreport.js"></script>
4
5 <style>
6 #draggable, #testend {
7 border: 1px solid black;
8 width: 100px;
9 height: 100px;
10 margin: 20px;
11 }
12 </style>
13
14 <div id="draggable" draggable="true">
15 </div>
16 <div id="testend">
17 </div>
18 <a id="link" href="https://www.chromium.org">A draggable link</a>
19
20 <p>
21 This tests WebKit's drag and drop thresholds. Due to the fine movements
22 required, manual testing is not possible.
23 </p>
24
25 <script>
26
27 function runTest(t, description, target, deltaX, deltaY, expectedDrag) {
28 const draggableCenterX = target.offsetLeft + target.offsetWidth / 2;
29 const draggableCenterY = target.offsetTop + target.offsetHeight / 2;
30
31 const testEnd = document.getElementById('testend');
32 const endCenterX = testEnd.offsetLeft + testEnd.offsetWidth / 2;
33 const endCenterY = testEnd.offsetTop + testEnd.offsetHeight / 2;
34
35 let dragStarted = false;
36 target.ondragstart = () => dragStarted = true;
37
38 const testEndPromise = new Promise((resolve, reject) => {
39 testEnd.onmouseup = () => resolve(true);
40
41 eventSender.mouseMoveTo(draggableCenterX, draggableCenterY);
42 eventSender.mouseDown();
43 setTimeout(() => {
44 eventSender.mouseMoveTo(
45 draggableCenterX + deltaX, draggableCenterY + deltaY);
46 eventSender.mouseUp();
47
48 eventSender.mouseMoveTo(endCenterX, endCenterY);
49 eventSender.mouseDown();
50 eventSender.mouseUp();
51 }, 100);
52 });
53
54 return testEndPromise.then(() => {
55 t.step(() => {
56 assert_equals(dragStarted, expectedDrag,
57 'dragstart did not occur as expected');
58 });
59 });
60 }
61
62 (() => {
63 const draggable = document.getElementById('draggable');
64 const link = document.getElementById('link');
65 link.onclick = (event) => event.preventDefault();
66
67 const testCases = [
68 ['No movement', draggable, 0, 0, false],
69 ['Small positive X movement', draggable, 2, 0, false],
70 ['Large positive X movement', draggable, 20, 0, true],
71 ['Small negative X movement', draggable, -2, 0, false],
72 ['Large negative X movement', draggable, -20, 0, true],
73 ['Small positive Y movement', draggable, 0, 2, false],
74 ['Large positive Y movement', draggable, 0, 20, true],
75 ['Small negative Y movement', draggable, 0, -2, false],
76 ['Large negative Y movement', draggable, 0, 20, true],
77 ['Small positive X + positive Y movement', draggable, 2, 2, false],
78 ['Small negative X + positive Y movement', draggable, -2, 2, false],
79 ['Small positive X + negative Y movement', draggable, 2, -2, false],
80 ['Small negative X + negative Y movement', draggable, -2, -2, false],
81 ['Link, small positive X movement', link, 2, 0, false],
82 ['Link, large positive X movement', link, 20, 0, true],
83 ['Link, small negative X movement', link, -2, 0, false],
84 ['Link, large negative X movement', link, -20, 0, true],
85 ['Link, small positive Y movement', link, 0, 2, false],
86 ['Link, large positive Y movement', link, 0, 20, true],
87 ['Link, small negative Y movement', link, 0, -2, false],
88 ['Link, large negative Y movement', link, 0, 20, true],
89 ];
90
91 for (const testCase of testCases) {
92 promise_test((t) => runTest(t, ...testCase), testCase[0]);
93 }
94 })();
95
96 </script>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/MouseEventManager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698