Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: components/browser_sync/profile_sync_service.cc

Issue 2401083003: [Sync] Adding integration tests for USS encryption and fixing a worker bug. (Closed)
Patch Set: Updated for rkaplow@'s comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service.cc
diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc
index 0a299982a6d4936324ee066eacb9607e2d45f760..86eb0068764fdffdf387853a9811d4bdb6c5ef26 100644
--- a/components/browser_sync/profile_sync_service.cc
+++ b/components/browser_sync/profile_sync_service.cc
@@ -1135,7 +1135,6 @@ void ProfileSyncService::OnPassphraseRequired(
<< syncer::PassphraseRequiredReasonToString(reason);
passphrase_required_reason_ = reason;
- // TODO(stanisc): http://crbug.com/351005: Does this support USS types?
const syncer::ModelTypeSet types = GetPreferredDataTypes();
if (data_type_manager_) {
// Reconfigure without the encrypted types (excluded implicitly via the
@@ -1163,7 +1162,6 @@ void ProfileSyncService::OnPassphraseAccepted() {
// Make sure the data types that depend on the passphrase are started at
// this time.
- // TODO(stanisc): http://crbug.com/351005: Does this support USS types?
const syncer::ModelTypeSet types = GetPreferredDataTypes();
if (data_type_manager_) {
// Re-enable any encrypted types if necessary.
@@ -2224,7 +2222,6 @@ void GetAllNodesRequestHelper::OnReceivedNodesForType(
void ProfileSyncService::GetAllNodes(
const base::Callback<void(std::unique_ptr<base::ListValue>)>& callback) {
- // TODO(stanisc): crbug.com/328606: Make this work for USS datatypes.
ModelTypeSet all_types = GetActiveDataTypes();
all_types.PutAll(syncer::ControlTypes());
scoped_refptr<GetAllNodesRequestHelper> helper =
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_uss_sync_test.cc ('k') | components/sync/engine/sync_encryption_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698