Move synchronously fetching to ResourceFetcher, as well as most of the logic

Move synchronously fetching to ResourceFetcher, as well as most of the logic
for synthesizing callbacks for memory cache hits.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157384

[abarth-chromium, 2013-09-06 19:28:27]

lgtm

https://codereview.chromium.org/24009002/diff/4001/Source/core/fetch/Resource...
File Source/core/fetch/ResourceFetcher.h (right):

https://codereview.chromium.org/24009002/diff/4001/Source/core/fetch/Resource...
Source/core/fetch/ResourceFetcher.h:84: unsigned long fetchSynchronously(const
ResourceRequest&, StoredCredentials, ResourceError&, ResourceResponse&,
Vector<char>&);
Are these parameters different from the ones in FetchRequest?

[commit-bot: I haz the power, 2013-09-06 19:28:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/24009002/4001

[Nate Chapin, 2013-09-06 19:34:03]

https://codereview.chromium.org/24009002/diff/4001/Source/core/fetch/Resource...
File Source/core/fetch/ResourceFetcher.h (right):

https://codereview.chromium.org/24009002/diff/4001/Source/core/fetch/Resource...
Source/core/fetch/ResourceFetcher.h:84: unsigned long fetchSynchronously(const
ResourceRequest&, StoredCredentials, ResourceError&, ResourceResponse&,
Vector<char>&);
On 2013/09/06 19:28:28, abarth wrote:
> Are these parameters different from the ones in FetchRequest?

ResourceRequest and StoredCredentials exist on FetchRequest, the rest don't. I
could see the argument for using a FetchRequest, but there's also the fact that
a bunch of the stuff on FetchRequest isn't relevant in the sync case.

[abarth-chromium, 2013-09-06 19:36:25]

On 2013/09/06 19:34:03, Nate Chapin wrote:
> ResourceRequest and StoredCredentials exist on FetchRequest, the rest don't. I
> could see the argument for using a FetchRequest, but there's also the fact
that
> a bunch of the stuff on FetchRequest isn't relevant in the sync case.

Ok.  This function isn't called in that many places, so it's probably not worth
making a struct.

[Nate Chapin, 2013-09-06 19:38:28]

On 2013/09/06 19:36:25, abarth wrote:
> On 2013/09/06 19:34:03, Nate Chapin wrote:
> > ResourceRequest and StoredCredentials exist on FetchRequest, the rest don't.
I
> > could see the argument for using a FetchRequest, but there's also the fact
> that
> > a bunch of the stuff on FetchRequest isn't relevant in the sync case.
> 
> Ok.  This function isn't called in that many places, so it's probably not
worth
> making a struct.

I think what might be worthwhile in the future is to have the synchronous load
populate a CachedResource and return that rather than requiring references to
several different objects that it populates.

[commit-bot: I haz the power, 2013-09-06 20:23:32]

Change committed as 157384