Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 24005002: Make TypedefMirror a direct descendant of TypeMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index 4d0fe517fc221b9a484387446e254ede35b54dcb..dba97774e59c29c627fccc2ff57c1cf6ed2fbcaa 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -442,11 +442,11 @@ InstanceMirror reflect(Object reflectee) {
}
}
-ClassMirror reflectType(Type key) {
+TypeMirror reflectType(Type key) {
return reflectClassByMangledName(getMangledTypeName(key));
}
-ClassMirror reflectClassByMangledName(String mangledName) {
+TypeMirror reflectClassByMangledName(String mangledName) {
String unmangledName = mangledGlobalNames[mangledName];
if (unmangledName == null) unmangledName = mangledName;
return reflectClassByName(s(unmangledName), mangledName);
@@ -454,7 +454,7 @@ ClassMirror reflectClassByMangledName(String mangledName) {
var classMirrors;
-ClassMirror reflectClassByName(Symbol symbol, String mangledName) {
+TypeMirror reflectClassByName(Symbol symbol, String mangledName) {
if (classMirrors == null) classMirrors = JsCache.allocate();
var mirror = JsCache.fetch(classMirrors, mangledName);
if (mirror != null) return mirror;
@@ -1692,10 +1692,6 @@ class JsTypedefMirror extends JsDeclarationMirror implements TypedefMirror {
JsFunctionTypeMirror get value => referent;
String get _prettyName => 'TypedefMirror';
-
- // TODO(zarah): This method doesn't belong here, since TypedefMirror shouldn't
- // be a subtype of ClassMirror.
- ClassMirror get originalDeclaration => this;
}
class JsFunctionTypeMirror implements FunctionTypeMirror {

Powered by Google App Engine
This is Rietveld 408576698