Add use counter for <svg>

Add use counter for <svg>

This patch adds a use counter for the SVGSVGElement. This will not
over count SVG, as we just record usecounter information once per page,
not per element on the page.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157434

[ojan, 2013-09-05 22:29:51]

LGTM


On Thu, Sep 5, 2013 at 3:29 PM, <pdr@chromium.org> wrote:

> Reviewers: esprehn, ojan,
>
> Description:
> Add use counter for <svg>
>
> This patch adds a use counter for the SVGSVGElement. This will not
> over count SVG, as we just record usecounter information once per page,
> not per element on the page.
>
> BUG=
>
> Please review this at
https://codereview.chromium.**org/24000002/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>
> Affected files (+4, -0 lines):
>   M Source/core/page/UseCounter.h
>   M Source/core/svg/SVGSVGElement.**cpp
>
>
> Index: Source/core/page/UseCounter.h
> diff --git a/Source/core/page/UseCounter.**h
> b/Source/core/page/UseCounter.**h
> index f70e966cece805512d309f6fff51ae**1ff07e163d..**
> f25c276a3cec8153ca943b47e2dc21**9c26fe47ad 100644
> --- a/Source/core/page/UseCounter.**h
> +++ b/Source/core/page/UseCounter.**h
> @@ -197,6 +197,7 @@ public:
>          UnprefixedAnimationIterationEv**ent,
>          PrefixedAndUnprefixedAnimation**IterationEvent,
>          EventReturnValue, // Legacy IE extension.
> +        SVGSVGElement,
>          // Add new features immediately above this line. Don't change
> assigned
>          // numbers of each items, and don't reuse unused slots.
>          NumberOfFeatures, // This enum value must be last.
> Index: Source/core/svg/SVGSVGElement.**cpp
> diff --git a/Source/core/svg/**SVGSVGElement.cpp b/Source/core/svg/**
> SVGSVGElement.cpp
> index c8d062d5fc7bc5764afb327f6b1ced**4d7bf6ad01..**
> f2e4f833a248a780a06f402b9f774e**8c09f2a764 100644
> --- a/Source/core/svg/**SVGSVGElement.cpp
> +++ b/Source/core/svg/**SVGSVGElement.cpp
> @@ -37,6 +37,7 @@
>  #include "core/page/Frame.h"
>  #include "core/page/FrameTree.h"
>  #include "core/page/FrameView.h"
> +#include "core/page/UseCounter.h"
>  #include "core/platform/**FloatConversion.h"
>  #include "core/platform/graphics/**FloatRect.h"
>  #include "core/platform/graphics/**transforms/AffineTransform.h"
> @@ -92,6 +93,8 @@ inline SVGSVGElement::SVGSVGElement(**const
> QualifiedName& tagName, Document& doc)
>      ASSERT(hasTagName(SVGNames::**svgTag));
>      ScriptWrappable::init(this);
>      registerAnimatedPropertiesForS**VGSVGElement();
> +
> +    UseCounter::count(&doc, UseCounter::SVGSVGElement);
>  }
>
>  PassRefPtr<SVGSVGElement> SVGSVGElement::create(const QualifiedName&
> tagName, Document& document)
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-09 02:57:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/24000002/1

[commit-bot: I haz the power, 2013-09-09 02:57:14]

Failed to apply patch for Source/core/page/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/UseCounter.h
  Hunk #1 FAILED at 197.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/UseCounter.h.rej

Patch:       Source/core/page/UseCounter.h
Index: Source/core/page/UseCounter.h
diff --git a/Source/core/page/UseCounter.h b/Source/core/page/UseCounter.h
index
f70e966cece805512d309f6fff51ae1ff07e163d..f25c276a3cec8153ca943b47e2dc219c26fe47ad
100644
--- a/Source/core/page/UseCounter.h
+++ b/Source/core/page/UseCounter.h
@@ -197,6 +197,7 @@ public:
         UnprefixedAnimationIterationEvent,
         PrefixedAndUnprefixedAnimationIterationEvent,
         EventReturnValue, // Legacy IE extension.
+        SVGSVGElement,
         // Add new features immediately above this line. Don't change assigned
         // numbers of each items, and don't reuse unused slots.
         NumberOfFeatures, // This enum value must be last.

[commit-bot: I haz the power, 2013-09-09 03:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/24000002/9001

[commit-bot: I haz the power, 2013-09-09 04:47:17]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-09-09 04:48:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/24000002/9001

[commit-bot: I haz the power, 2013-09-09 04:48:46]

Change committed as 157434