Issue 23998002: cc: Fixed computation of dropped frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23998002: cc: Fixed computation of dropped frames. (Closed)

Created:
7 years, 3 months ago by ernstm

Modified:
7 years, 3 months ago

Reviewers:
nduca, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cc: Fixed computation of dropped frames. - Computation of dropped frames now correctly accounts for multi-frame drops. - A welcome side-effect is that variance of the percentage_dropped metric is reduced significantly. - Heads-up for the perf sherrifs: percentage_dropped will increase quite a bit with this patch. R=tonyg@chromium.org, nduca@chromium.org BUG=264308 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221825

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	cc/debug/frame_rate_counter.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/perf/metrics/smoothness.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/perf/metrics/smoothness.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/23998002/1

7 years, 3 months ago (2013-09-06 20:00:19 UTC) #4

Message was sent while issue was closed.

Change committed as 221825

Expand Messages | Collapse Messages