Show host owner rather than xmpp login on the UI where available.

Show host owner rather than xmpp login on the UI where available.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224901

[rmsousa, 2013-09-20 01:16:23]

Note: I don't have a mac, nor a functioning windows setup. This is a simple
change, and I used the trybots to check that it compiles, but that's the extent
of my "testing".

Explanation of the change: service account setups have a "host_owner" config
field that contains the email of the real owner (while "xmpp_login" has the
service account's email, which is used to connect to xmpp). If that field is not
there, it means it's not a service account setup, and "xmpp_login" is also the
email of the owner.

[Lambros, 2013-09-20 02:52:02]

lgtm, as far as I can tell from the email. Please upload the patch again, as
Rietveld is showing an error when I try to view the diffs.

[rmsousa, 2013-09-20 19:05:15]

reuploaded

[alexeypa (please no reviews), 2013-09-20 20:33:24]

https://codereview.chromium.org/23995027/diff/27001/remoting/host/win/elevate...
File remoting/host/win/elevated_controller.cc (right):

https://codereview.chromium.org/23995027/diff/27001/remoting/host/win/elevate...
remoting/host/win/elevated_controller.cc:227: if
(!(config_dict->GetString(kHostOwner, &email) ||
nit: Is there a way to make it more explicit that we would use either kHostOwner
or kXmppLogin, but we prefer kHostOwner? It is very easy to miss it while
reading the code.

[rmsousa, 2013-09-20 23:10:50]

https://codereview.chromium.org/23995027/diff/27001/remoting/host/win/elevate...
File remoting/host/win/elevated_controller.cc (right):

https://codereview.chromium.org/23995027/diff/27001/remoting/host/win/elevate...
remoting/host/win/elevated_controller.cc:227: if
(!(config_dict->GetString(kHostOwner, &email) ||
On 2013/09/20 20:33:24, alexeypa wrote:
> nit: Is there a way to make it more explicit that we would use either
kHostOwner
> or kXmppLogin, but we prefer kHostOwner? It is very easy to miss it while
> reading the code.

Done.

[alexeypa (please no reviews), 2013-09-23 22:37:01]

lgtm

https://codereview.chromium.org/23995027/diff/32001/remoting/host/win/elevate...
File remoting/host/win/elevated_controller.cc (right):

https://codereview.chromium.org/23995027/diff/32001/remoting/host/win/elevate...
remoting/host/win/elevated_controller.cc:228: if
(!config_dict->GetString(kXmppLogin, &email)) {
nit: no need for this pair of brackets.

[commit-bot: I haz the power, 2013-09-23 22:46:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/23995027/32001

[rmsousa, 2013-09-23 22:49:06]

On 2013/09/23 22:37:01, alexeypa wrote:
> lgtm
> 
>
https://codereview.chromium.org/23995027/diff/32001/remoting/host/win/elevate...
> File remoting/host/win/elevated_controller.cc (right):
> 
>
https://codereview.chromium.org/23995027/diff/32001/remoting/host/win/elevate...
> remoting/host/win/elevated_controller.cc:228: if
> (!config_dict->GetString(kXmppLogin, &email)) {
> nit: no need for this pair of brackets.

This file uses optional single-line brackets elsewhere, I'd rather leave it as
is for consistency.

[commit-bot: I haz the power, 2013-09-24 04:48:47]

Change committed as 224901