Issue 23993003: linux_aura: Use the linux assets for the window caption buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23993003: linux_aura: Use the linux assets for the window caption buttons. (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher

Modified:
7 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_aura: Use the linux assets for the window caption buttons. Previously, we were using the windows assets. As is, this is functional, but will require further patches to get the button spacing correct. BUG=281788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221875

Patch Set 1 #

Patch Set 2 : Use an ifdef for desktop_linux #

Patch Set 3 : Fix grd files. #

Patch Set 4 : Fix the other case of this. #

Patch Set 5 : I suspect rietveld is confused. Reuploading patch. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -10 lines)			Patch
	M	build/common.gypi	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download
	M	ui/resources/ui_resources.grd	View	1 2 3	5 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

oshima

I haven't looked into details, but build failures look real.

7 years, 3 months ago (2013-09-05 20:55:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/23993003/89001

7 years, 3 months ago (2013-09-07 00:25:42 UTC) #5

Message was sent while issue was closed.

Change committed as 221875

Expand Messages | Collapse Messages