Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 23992006: Warm up DWM prior to lowering token. (Closed)

Created:
7 years, 3 months ago by apatrick_chromium
Modified:
7 years, 3 months ago
Reviewers:
jbauman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org
Visibility:
Public.

Description

Warm up DWM prior to lowering token. DWM was introduced with Windows Vista. DwmFlush seems to be sufficient to warm it up before lowering the token. DWM is required to present to a window with Vista and later and this allows us to do so with the GPU process sandbox enabled. Enabling the sandbox for this case is not in this patch. Other things are required, such as making the sandbox broker allow certain event objects to be opened from the GPU process. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/gpu/gpu_main.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
7 years, 3 months ago (2013-09-06 22:18:12 UTC) #1
jbauman
lgtm, though I am a bit worried that this will hurt startup time.
7 years, 3 months ago (2013-09-06 22:19:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/23992006/1
7 years, 3 months ago (2013-09-06 22:34:04 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 02:09:09 UTC) #4
Message was sent while issue was closed.
Change committed as 221859

Powered by Google App Engine
This is Rietveld 408576698