Issue 23992005: Fix for aliasing in device-independent ovals on Nexus 10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23992005: Fix for aliasing in device-independent ovals on Nexus 10. (Closed)

Created:
7 years, 3 months ago by jvanverth1

Modified:
7 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for aliasing in device-independent ovals on Nexus 10. Switch to using two attributes so that dFdx and dFdy generate valid results. Committed: http://code.google.com/p/skia/source/detail?r=11137

Patch Set 2 : Fix an indent. #

Total comments: 1

Patch Set 3 : One more indent issue. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
	M	src/gpu/GrOvalRenderer.cpp	View	1 2	4 chunks	+24 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

https://codereview.chromium.org/23992005/diff/3001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/23992005/diff/3001/src/gpu/GrOvalRenderer.cpp#newcode601 src/gpu/GrOvalRenderer.cpp:601: {kVec2f_GrVertexAttribType, sizeof(GrPoint), kEffect_GrVertexAttribBinding}, alignment on kEffect?

7 years, 3 months ago (2013-09-06 18:35:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23992005/9001

7 years, 3 months ago (2013-09-06 19:38:26 UTC) #4

Message was sent while issue was closed.

Change committed as 11137