Issue 23991003: roll gyp 1716:1722

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23991003: roll gyp 1716:1722 (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll gyp 1716:1722 1717: Prevent propagation of shared_library's link_settings 1718: ninja&make/mac: Fix .strings encoding regression from r1707. 1719: ninja: Don't write subninjas for ninja files that end up being empty. 1720: Remove unused link_languages. 1721: ninja/posix: Don't link c-file-only targets to libstdc++. 1722: Add a flag to enable the fix for r1717 BUG=280718 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222577

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : 1722 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/23991003/1

7 years, 3 months ago (2013-09-07 03:55:31 UTC) #2

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-07 04:10:26 UTC) #3

Nico

7 years, 3 months ago (2013-09-11 16:58:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r222577 (presubmit successful).

Expand Messages | Collapse Messages