media/gpu/video_encode_accelerator_unittest.cc - Issue 2398883002: Add support for multiple V4L2 video devices of the same type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/video_encode_accelerator_unittest.cc

Issue 2398883002: Add support for multiple V4L2 video devices of the same type. (Closed)

Patch Set: Address comments, reorganize V4L2Device::Type. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/video_encode_accelerator_unittest.cc

diff --git a/media/gpu/video_encode_accelerator_unittest.cc b/media/gpu/video_encode_accelerator_unittest.cc

index e684cb08e42019a44d99fc06b256e69bb3c3ed2e..45da3ff52968fed7391297723afc9de12f694273 100644

--- a/media/gpu/video_encode_accelerator_unittest.cc

+++ b/media/gpu/video_encode_accelerator_unittest.cc

@@ -1131,7 +1131,7 @@ std::unique_ptr<VideoEncodeAccelerator> VEAClient::CreateFakeVEA() {

std::unique_ptr<VideoEncodeAccelerator> VEAClient::CreateV4L2VEA() {

std::unique_ptr<VideoEncodeAccelerator> encoder;

#if defined(OS_CHROMEOS) && defined(USE_V4L2_CODEC)

- scoped_refptr<V4L2Device> device = V4L2Device::Create(V4L2Device::kEncoder);

+ scoped_refptr<V4L2Device> device = V4L2Device::Create();

if (device)

encoder.reset(new V4L2VideoEncodeAccelerator(device));

#endif