Issue 23986002: Fix TSan issues for data_fetcher_shared_memory_base_unittest.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23986002: Fix TSan issues for data_fetcher_shared_memory_base_unittest.cc. (Closed)

Created:
7 years, 3 months ago by timvolodine

Modified:
7 years, 3 months ago

Reviewers:
bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix TSan issues for data_fetcher_shared_memory_base_unittest.cc. This patch moves the test for valid handle to a more appropriate place. Currently the expectation itself in the test can cause a race condition because it implicitly looks up a shared mem pointer from a different thread. BUG=284959 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221444