Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 23985006: base: Split logging functions and PerfTimeLogger out of perftimer.h (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, grt+watch_chromium.org, amit, jam, chrome-speed-team+watch_google.com, feature-media-reviews_chromium.org, robertshield, erikwright (departed), darin-cc_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

base: Split logging functions and PerfTimeLogger out of perftimer.h Soon PerfTimer will move into base/timer/ directory as it is already used by production code. This splits the logging stuff into their owns files and also moves PerfTimeLogger into its own files. BUG=None TEST=base_unittests, ipc_perftests, etc... R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223486

Patch Set 1 #

Patch Set 2 : fix visitedlink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -135 lines) Patch
M base/base.gyp View 2 chunks +6 lines, -1 line 0 comments Download
A base/test/perf_log.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + base/test/perf_log.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M base/test/perf_test_suite.cc View 3 chunks +5 lines, -6 lines 0 comments Download
A base/test/perf_time_logger.h View 1 chunk +37 lines, -0 lines 0 comments Download
A base/test/perf_time_logger.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M base/test/perftimer.h View 3 chunks +2 lines, -54 lines 0 comments Download
M chrome/test/perf/url_parse_perftest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome_frame/test/perf/silverlight.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M components/visitedlink/test/visitedlink_perftest.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_perftests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/ffmpeg/ffmpeg_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M net/disk_cache/disk_cache_perftest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Please, take a look. Thanks,
7 years, 3 months ago (2013-09-11 23:06:51 UTC) #1
grt (UTC plus 2)
rubberstamp lgtm for chrome_frame/*
7 years, 3 months ago (2013-09-12 14:09:35 UTC) #2
tfarina
Lei -> chrome Carlos -> ipc Ami -> media (I never know who still works ...
7 years, 3 months ago (2013-09-13 00:15:53 UTC) #3
Ami GONE FROM CHROMIUM
media LGTM
7 years, 3 months ago (2013-09-13 00:27:35 UTC) #4
bbudge
ppapi LGTM
7 years, 3 months ago (2013-09-13 00:28:53 UTC) #5
Lei Zhang
chrome/ lgtm
7 years, 3 months ago (2013-09-13 00:30:09 UTC) #6
eroman
net/ LGTM
7 years, 3 months ago (2013-09-13 18:07:47 UTC) #7
cpu_(ooo_6.6-7.5)
ipc lgtm
7 years, 3 months ago (2013-09-13 21:06:06 UTC) #8
tfarina
Darin, would you be willing to rubber stamp this in place of Brett?
7 years, 3 months ago (2013-09-13 22:14:59 UTC) #9
brettw
lgtm
7 years, 3 months ago (2013-09-16 17:49:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23985006/9001
7 years, 3 months ago (2013-09-16 18:01:39 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 00:34:42 UTC) #12
Message was sent while issue was closed.
Change committed as 223486

Powered by Google App Engine
This is Rietveld 408576698