Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy_unittest.cc

Issue 23983014: [Activity Log] when extension is uninstalled, delete data about it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed bug in test Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
index b3de9dae3a766ccb88af27e0cee5ffd200e2478e..6315b8db58e5330c37f2f97a7567a6e1906d5086 100644
--- a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
@@ -926,6 +926,64 @@ TEST_F(CountingPolicyTest, RemoveSpecificURLs) {
policy->Close();
}
+TEST_F(CountingPolicyTest, RemoveExtensionData) {
+ CountingPolicy* policy = new CountingPolicy(profile_.get());
+
+ // Use a mock clock to ensure that events are not recorded on the wrong day
+ // when the test is run close to local midnight.
+ base::SimpleTestClock* mock_clock = new base::SimpleTestClock();
+ mock_clock->SetNow(base::Time::Now().LocalMidnight() +
+ base::TimeDelta::FromHours(12));
+ policy->SetClockForTesting(scoped_ptr<base::Clock>(mock_clock));
+
+ // Record some actions
+ scoped_refptr<Action> action = new Action("deleteextensiondata",
+ mock_clock->Now(),
+ Action::ACTION_DOM_ACCESS,
+ "lets");
+ action->mutable_args()->AppendString("vamoose");
+ action->set_page_title("Google");
+ action->set_arg_url(GURL("http://www.google.com"));
+ policy->ProcessAction(action);
+ policy->ProcessAction(action);
+ policy->ProcessAction(action);
+
+ scoped_refptr<Action> action2 = new Action("dontdelete",
+ mock_clock->Now(),
+ Action::ACTION_DOM_ACCESS,
+ "lets");
+ action->mutable_args()->AppendString("vamoose");
+ action->set_page_title("Google");
+ action->set_arg_url(GURL("http://www.google.com"));
+ policy->ProcessAction(action2);
+
+ policy->Flush();
+ policy->RemoveExtensionData("deleteextensiondata");
+
+ CheckReadFilteredData(
+ policy,
+ "deleteextensiondata",
+ Action::ACTION_ANY,
+ "",
+ "",
+ "",
+ -1,
+ base::Bind(
+ &CountingPolicyTest::RetrieveActions_FetchFilteredActions0));
+
+ CheckReadFilteredData(
+ policy,
+ "dontdelete",
+ Action::ACTION_ANY,
+ "",
+ "",
+ "",
+ -1,
+ base::Bind(
+ &CountingPolicyTest::RetrieveActions_FetchFilteredActions1));
+ policy->Close();
+}
+
TEST_F(CountingPolicyTest, DeleteActions) {
CountingPolicy* policy = new CountingPolicy(profile_.get());
// Disable row expiration for this test by setting a time before any actions

Powered by Google App Engine
This is Rietveld 408576698