Issue 23983013: ash: Rename LauncherAlignmentMenu to ShelfAlignmentMenu and move to shelf/ directory.

Issue 23983013: ash: Rename LauncherAlignmentMenu to ShelfAlignmentMenu and move to shelf/ directory. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
xiyuan, James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Rename LauncherAlignmentMenu to ShelfAlignmentMenu and move to shelf/ directory. Minor cleanup, the renames started. BUG=248353 R=jamescook@chromium.org,xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222298

Patch Set 2 : fix header include guard #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -145 lines)			Patch
M	ash/ash.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	ash/launcher/launcher_alignment_menu.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	ash/launcher/launcher_alignment_menu.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
A +	ash/shelf/shelf_alignment_menu.h	View	1	3 chunks	+8 lines, -8 lines	1 comment	Download
A +	ash/shelf/shelf_alignment_menu.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	ash/shell/context_menu.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_context_menu.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_context_menu.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

xiyuan

lgtm https://codereview.chromium.org/23983013/diff/1/ash/shelf/shelf_alignment_menu.h File ash/shelf/shelf_alignment_menu.h (right): https://codereview.chromium.org/23983013/diff/1/ash/shelf/shelf_alignment_menu.h#newcode6 ash/shelf/shelf_alignment_menu.h:6: #define ASH_WM_LAUNCHER_LAUNCHER_ALIGNMENT_MENU_H_ Please update the guardian name.

7 years, 3 months ago (2013-09-07 15:20:34 UTC) #2

tfarina

https://codereview.chromium.org/23983013/diff/1/ash/shelf/shelf_alignment_menu.h File ash/shelf/shelf_alignment_menu.h (right): https://codereview.chromium.org/23983013/diff/1/ash/shelf/shelf_alignment_menu.h#newcode6 ash/shelf/shelf_alignment_menu.h:6: #define ASH_WM_LAUNCHER_LAUNCHER_ALIGNMENT_MENU_H_ On 2013/09/07 15:20:34, xiyuan wrote: > Please ...

7 years, 3 months ago (2013-09-07 15:25:12 UTC) #3

xiyuan

7 years, 3 months ago (2013-09-07 15:30:18 UTC) #4

tfarina

https://codereview.chromium.org/23983013/diff/9001/ash/shelf/shelf_alignment_menu.h File ash/shelf/shelf_alignment_menu.h (right): https://codereview.chromium.org/23983013/diff/9001/ash/shelf/shelf_alignment_menu.h#newcode5 ash/shelf/shelf_alignment_menu.h:5: #ifndef ASH_SHELF_SHELF_ALIGNMENT_MENU_H_ Fixed. :p

7 years, 3 months ago (2013-09-07 15:53:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23983013/9001

7 years, 3 months ago (2013-09-09 23:18:10 UTC) #7

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=195415

7 years, 3 months ago (2013-09-10 09:03:31 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23983013/9001

7 years, 3 months ago (2013-09-10 12:01:07 UTC) #9

Message was sent while issue was closed.

Change committed as 222298

Expand Messages | Collapse Messages