Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 23983010: Log a warning if we try to load a URL longer than kMaxURLChars. (Closed)

Created:
7 years, 3 months ago by benm (inactive)
Modified:
7 years, 3 months ago
Reviewers:
joth, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Log a warning if we try to load a URL longer than kMaxURLChars. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222094

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
benm (inactive)
ptal
7 years, 3 months ago (2013-09-06 20:08:11 UTC) #1
joth
lgtm
7 years, 3 months ago (2013-09-06 20:48:37 UTC) #2
benm (inactive)
+sky for OWNERS as jochen is OOO
7 years, 3 months ago (2013-09-08 12:26:55 UTC) #3
sky
LGTM
7 years, 3 months ago (2013-09-09 15:30:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/23983010/8001
7 years, 3 months ago (2013-09-09 15:37:18 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 21:23:45 UTC) #6
Message was sent while issue was closed.
Change committed as 222094

Powered by Google App Engine
This is Rietveld 408576698